Skip to content

Update TS codegen - change getFullyQualifiedName return type from string to string literal #8421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aardappel merged 6 commits into from
Aug 18, 2025
Merged

Update TS codegen - change getFullyQualifiedName return type from string to string literal #8421

aardappel merged 6 commits into from
Aug 18, 2025

Conversation

@rametta
Copy link
Contributor

@rametta rametta commented Oct 8, 2024

Makes the return type of static getFullyQualifiedName(): string be a string literal instead of just the string type. This helps make the return type be more specific instead of just a generic string - which helps with other tools that run static analysis on the generated code types.

Changes:

// before
static getFullyQualifiedName(): string {
  return "Some.Name";
}

// after
static getFullyQualifiedName(): "Some.Name" {
  return "Some.Name";
}

@google-cla
Copy link

google-cla bot commented Oct 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added c++ codegen Involving generating code from schema javascript typescript labels Oct 8, 2024
@rametta
Update ts codegen
a47e392 
Makes the return type of `static getFullyQualifiedName()` be a string literal instead of just the string type

Update tests
@rametta rametta force-pushed the ts-codegen-update branch from af7aa08 to a47e392 Compare October 8, 2024 15:00
@rametta
Copy link
Contributor Author

rametta commented Oct 8, 2024

Just signed the CLA, thanks!

@rametta
Copy link
Contributor Author

rametta commented Oct 25, 2024

@bjornharrtell sorry to tag you but I saw you on some other TS related PR's and thought you might be able to review this one too. Would be much appreciated

bjornharrtell
bjornharrtell approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@bjornharrtell bjornharrtell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rametta
Copy link
Contributor Author

rametta commented Oct 30, 2024

Any chance we could merge this one? Or do we need another approval first?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2025

This pull request is stale because it has been open 6 months with no activity. Please comment or label not-stale, or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Aug 15, 2025
@bjornharrtell
Copy link
Collaborator

bjornharrtell commented Aug 16, 2025

@aardappel merge?

@github-actions github-actions bot removed the stale label Aug 16, 2025
@aardappel aardappel merged commit 067bfdb into google:master Aug 18, 2025
48 of 51 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Sep 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjornharrtell bjornharrtell bjornharrtell approved these changes

Assignees

No one assigned

Labels

c++ codegen Involving generating code from schema javascript typescript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rametta @bjornharrtell @aardappel