Bugfix: grpc python code generation location and file suffix #8359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fliiiix
force-pushed
the
bugfix/grpc-python-generation
branch
from
7519c47 to
95c0ab2
Compare
anton-bobukh
previously approved these changes
Jul 23, 2024
Contributor
Author
|
Can this be merged @dbaileychess or does it need something else? |
Contributor
Author
|
Any update if this can be merged? @dbaileychess @anton-bobukh |
fliiiix
force-pushed
the
bugfix/grpc-python-generation
branch
from
4aad523 to
e69f52b
Compare
fliiiix
force-pushed
the
bugfix/grpc-python-generation
branch
from
e69f52b to
d1fabd4
Compare
Contributor
Author
|
Rebased to master any chance this can be merged @dbaileychess @anton-bobukh as this still breaks imports in python |
fliiiix
force-pushed
the
bugfix/grpc-python-generation
branch
from
d1fabd4 to
4034a5d
Compare
Contributor
Author
|
rebased again |
fliiiix
force-pushed
the
bugfix/grpc-python-generation
branch
from
4034a5d to
8e8cf3a
Compare
Having filenames with . like `file.fb.grcp` is not great for Python. Since dots are used for namespaces. Replacing all of them with _ eg suffix `foo.bar.baz` will become `foo_bar_baz`. Restoring the previous default `_fb` suffix.
This fixes a regression introduced with: fb9afba And generates the grpc file in the namespace folder again.
fliiiix
force-pushed
the
bugfix/grpc-python-generation
branch
from
8e8cf3a to
e8dc507
Compare
Contributor
Author
|
@aardappel or @dbaileychess any chance this can also be merged to fix the regression after this was merged now #8500 |
aardappel
approved these changes
Jun 24, 2025
Collaborator
|
CI issues seem unrelated |
Collaborator
|
Thanks :) |
Contributor
Author
|
Thank you ✨ good to see that flatbuffers is still maintained |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #8356.
This addresses the regression for the location where the
grpcfile is generated andchanges the default suffix back to
_fbagain instead of.fb.(See commit messages for more details).