Trying to fix bazel on macOS and Xcode 14.3 #8304
Merged
+89
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustiikhalil
changed the title
mustiikhalil
force-pushed
the
mmk/bazel
branch
2 times, most recently
from
b6cc432 to
325fa94
Compare
mustiikhalil
force-pushed
the
mmk/bazel
branch
2 times, most recently
from
7e89a8f to
f99a467
Compare
jkuszmaul
reviewed
May 17, 2024
Fetching boringssl within the flatbuffers repository, to patch the issues of not being able to upgrade to Xcode 14.3 due to buildkite throwing errors. The patch was inspired by the tenserflow patch tensorflow/tensorflow#60191 (comment) Removes references of swift from the windows pipeline for bazel Sets github actions to use xcode 14.3 for kotlin and sets the macOS build for intel cpus.
mustiikhalil
commented
May 17, 2024
Collaborator
Author
|
Ah linux is now broken :/ |
Remove comment that is not relevant any longer.
dbaileychess
approved these changes
May 29, 2024
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
* Fixes Bazel issues for windows and ci Fetching boringssl within the flatbuffers repository, to patch the issues of not being able to upgrade to Xcode 14.3 due to buildkite throwing errors. The patch was inspired by the tenserflow patch tensorflow/tensorflow#60191 (comment) Removes references of swift from the windows pipeline for bazel Sets github actions to use xcode 14.3 for kotlin and sets the macOS build for intel cpus. * Update build.yml Remove comment that is not relevant any longer. --------- Co-authored-by: Derek Bailey <[email protected]>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
* Fixes Bazel issues for windows and ci Fetching boringssl within the flatbuffers repository, to patch the issues of not being able to upgrade to Xcode 14.3 due to buildkite throwing errors. The patch was inspired by the tenserflow patch tensorflow/tensorflow#60191 (comment) Removes references of swift from the windows pipeline for bazel Sets github actions to use xcode 14.3 for kotlin and sets the macOS build for intel cpus. * Update build.yml Remove comment that is not relevant any longer. --------- Co-authored-by: Derek Bailey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following fixes the issue we are facing with
buildkiteand Xcode 14.3 by fetchingboringsslwithin the flatbuffers repository and applying the patch directly. And also stops fetching swift for bazel on windowsdepends on #8307
Closes #8301