Skip to content

Conversation

@p0fi
Copy link
Contributor

@p0fi p0fi commented Mar 11, 2024

📖 Description

The previous license value was not suitable for most software license scanners. Listing the actual license string in the package.json fixes this

The previous license value was not suitable for most software license scanners. Listing the actual license string in the package.json fixes this
@github-actions github-actions bot added the json label Mar 11, 2024
@p0fi
Copy link
Contributor Author

p0fi commented Mar 11, 2024

It seems that the build on macOS is broken on master due to a warning which is treated as an error due to -Werror. Here is the run: https://buildkite.com/bazel/flatbuffers/builds/9312#018e2de2-ad09-403d-b3c8-1cfb90b958b0

@dbaileychess
Copy link
Collaborator

Why is this an issue now? I did a trivial change a year ago with the same textual blurb?

d44ce00

@dbaileychess dbaileychess merged commit b1f617f into google:master Mar 11, 2024
This was referenced Mar 11, 2024
@p0fi
Copy link
Contributor Author

p0fi commented Mar 12, 2024

For us its an issue now since we started to use flatbuffers this week :D
Thanks for merging! 👍

@p0fi p0fi deleted the fix-license-info branch March 12, 2024 10:04
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
The previous license value was not suitable for most software license scanners. Listing the actual license string in the package.json fixes this
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
The previous license value was not suitable for most software license scanners. Listing the actual license string in the package.json fixes this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants