[Rust] Add the Allocator trait for the builder API #8106
Merged
+658
−449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I believe this change is semver compatible but do let me know if you see a place where this is not the case. The only open question I have is whether the |
bsilver8192
reviewed
Oct 5, 2023
adsnaider
force-pushed
the
allocator_trait
branch
from
984b0fd to
43eb1e5
Compare
CasperN
reviewed
Oct 5, 2023
Collaborator
|
Nice! Thank you for the PR |
CasperN
reviewed
Oct 5, 2023
CasperN
reviewed
Oct 5, 2023
adsnaider
force-pushed
the
allocator_trait
branch
2 times, most recently
from
e80fb71 to
de9c6b2
Compare
CasperN
previously approved these changes
Oct 6, 2023
Collaborator
CasperN
left a comment
CasperN
left a comment
There was a problem hiding this comment.
LGTM with some nitpicks
adsnaider
force-pushed
the
allocator_trait
branch
from
de9c6b2 to
0e297db
Compare
adsnaider
force-pushed
the
allocator_trait
branch
from
0e297db to
dbe5bc6
Compare
CasperN
approved these changes
Oct 7, 2023
frc971-automation
pushed a commit
to frc971/971-Robot-Code
that referenced
this pull request
Feb 19, 2024
This commit is just backporting the change that got merged upstream: google/flatbuffers#8106 Change-Id: I7b7c7b507f8f2efc0213868d9911c8009274fd6e Signed-off-by: James Kuszmaul <[email protected]>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
* Add an Allocator trait for FlatBufferBuilder * Update rust generated code
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
* Add an Allocator trait for FlatBufferBuilder * Update rust generated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Allocator trait that is now used in FlatBufferBuilder. Fixes #7385