Skip to content

Make eslint less pedantic #8012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aardappel merged 2 commits into from
Jul 10, 2023
Merged

Make eslint less pedantic #8012

aardappel merged 2 commits into from
Jul 10, 2023

Conversation

@OptoCloud
Copy link
Contributor

@OptoCloud OptoCloud commented Jun 27, 2023

When using eslint with generated TS files eslint is not very happy, this blindfolds eslint so it doesnt see all the bad stuff.

Example eslint output:

   5:3   warning  'unionListToServerPayload' is defined but never used  @typescript-eslint/no-unused-vars
   6:3   warning  'unionToServerPayload' is defined but never used      @typescript-eslint/no-unused-vars
  32:20  warning  Forbidden non-null assertion                          @typescript-eslint/no-non-null-assertion
  33:21  warning  Forbidden non-null assertion                          @typescript-eslint/no-non-null-assertion
  37:20  warning  Forbidden non-null assertion                          @typescript-eslint/no-non-null-assertion
  38:21  warning  Forbidden non-null assertion                          @typescript-eslint/no-non-null-assertion
  41:11  warning  'T' is defined but never used                         @typescript-eslint/no-unused-vars
  41:45  warning  Unexpected any. Specify a different type              @typescript-eslint/no-explicit-any
  41:51  warning  Unexpected any. Specify a different type              @typescript-eslint/no-explicit-any
  42:20  warning  Forbidden non-null assertion                          @typescript-eslint/no-non-null-assertion
  43:21  warning  Forbidden non-null assertion                          @typescript-eslint/no-non-null-assertion

@github-actions github-actions bot added c++ javascript typescript codegen Involving generating code from schema grpc labels Jun 27, 2023
@OptoCloud
Copy link
Contributor Author

OptoCloud commented Jul 5, 2023

@dbaileychess Can I get a review / merge on this? thanks 😄

@aardappel
Copy link
Collaborator

aardappel commented Jul 10, 2023

Since @dbaileychess is away, I am going to approve it, since it is indeed just a comment.. I have no knowledge of eslint though, so I am just assuming this is ok.

@aardappel aardappel enabled auto-merge (squash) July 10, 2023 15:43
@aardappel aardappel merged commit 48da238 into google:master Jul 10, 2023
@OptoCloud OptoCloud deleted the patch-1 branch July 10, 2023 16:30
@bjornharrtell bjornharrtell mentioned this pull request Aug 21, 2023
Merged
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
@OptoCloud
Make eslint less pedantic (google#8012)
ce84e29 
* Disable eslint spam

* Generate TS example files
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
@OptoCloud
Make eslint less pedantic (google#8012)
f7b5734 
* Disable eslint spam

* Generate TS example files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aardappel aardappel aardappel approved these changes

Assignees

No one assigned

Labels

c++ codegen Involving generating code from schema grpc javascript typescript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OptoCloud @aardappel