This repository was archived by the owner on May 29, 2023. It is now read-only.
Fix anchoring of delegate regular expressions#21
Merged
raphlinus merged 1 commit intogoogle:masterfrom Aug 11, 2017
Merged
Conversation
Before, e.g. a lookahead like `(?=x|a)` would be wrong. The delegate RE for the `x|a` part inside was compiled as `^x|a`. This means only the `x` was anchored, but not `a`. Fix it by adding a non-capturing group so that the delegate is `^(?:x|a)`, which results in correct anchoring in this case (and possibly others).
7 tasks
Contributor
|
Thanks for the fixes, appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, e.g. a lookahead like
(?=x|a)would be wrong. The delegate REfor the
x|apart inside was compiled as^x|a. This means only thexwas anchored, but nota.Fix it by adding a non-capturing group so that the delegate is
^(?:x|a), which results in correct anchoring in this case (andpossibly others).