turn on prefer-const#52
Merged
philipwalton merged 3 commits intogoogle:masterfrom Oct 14, 2018
Merged
Conversation
Closed
philipwalton
suggested changes
Oct 13, 2018
| // 'object-shorthand': 0, | ||
| // 'prefer-arrow-callback': 0, | ||
| // 'prefer-const': 0, | ||
| 'prefer-const': ["error", {"destructuring": "all"}], |
Contributor
There was a problem hiding this comment.
Switch this to single quotes so the tests pass.
philipwalton
suggested changes
Oct 13, 2018
| // 'object-shorthand': 0, | ||
| // 'prefer-arrow-callback': 0, | ||
| // 'prefer-const': 0, | ||
| 'prefer-const': ['error', {'destructuring': 'all'}], |
Contributor
There was a problem hiding this comment.
Sorry, should have also mentioned, can you remove the quotes from the object key destructuring? It should be:
'prefer-const': ['error', {destructuring: 'all'}],
Contributor
Author
There was a problem hiding this comment.
You know, I have "allow edits from maintainers" turned on ;)
Contributor
There was a problem hiding this comment.
I did not know that! But it all looks good now anyway, thanks!
philipwalton
approved these changes
Oct 14, 2018
RandomByte
added a commit
to SAP/ui5-fs
that referenced
this pull request
Nov 15, 2018
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
RandomByte
added a commit
to SAP/ui5-builder
that referenced
this pull request
Nov 15, 2018
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
RandomByte
added a commit
to SAP/ui5-project
that referenced
this pull request
Nov 15, 2018
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
RandomByte
added a commit
to SAP/ui5-server
that referenced
this pull request
Nov 15, 2018
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
RandomByte
added a commit
to SAP/ui5-cli
that referenced
this pull request
Nov 15, 2018
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
RandomByte
added a commit
to SAP/ui5-cli
that referenced
this pull request
Nov 15, 2018
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
RandomByte
added a commit
to SAP/ui5-server
that referenced
this pull request
Nov 15, 2018
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
RandomByte
added a commit
to SAP/ui5-project
that referenced
this pull request
Nov 15, 2018
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
RandomByte
added a commit
to SAP/ui5-builder
that referenced
this pull request
Nov 15, 2018
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
RandomByte
added a commit
to SAP/ui5-fs
that referenced
this pull request
Nov 15, 2018
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
tobiasso85
pushed a commit
to SAP/ui5-builder
that referenced
this pull request
Dec 17, 2018
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 24, 2025
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 24, 2025
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 24, 2025
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 24, 2025
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 24, 2025
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 24, 2025
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 25, 2025
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 25, 2025
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 25, 2025
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 25, 2025
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 25, 2025
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 26, 2025
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 26, 2025
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
d3xter666
pushed a commit
to UI5/cli
that referenced
this pull request
Sep 26, 2025
ESLint rule update will follow with eslint-config-google dependency bump. See google/eslint-config-google#52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
per https://google.github.io/styleguide/jsguide.html#features-use-const-and-let