Skip to content

JDK 17: NoSuchMethodError for methods in com.sun.tools.javac.code.Scope that take a com.sun.tools.javac.util.Filter #2330

@cushon

Description

@cushon

e.g.

Error:       java.lang.NoSuchMethodError: 'java.lang.Iterable com.sun.tools.javac.code.Scope$WriteableScope.getSymbols(com.sun.tools.javac.util.Filter)'
Error:    	at com.google.errorprone.bugpatterns.threadsafety.ImmutableAnalysis.areFieldsImmutable(ImmutableAnalysis.java:251)
Error:    	at com.google.errorprone.bugpatterns.threadsafety.ImmutableAnalysis.checkForImmutability(ImmutableAnalysis.java:131)
Error:    	at com.google.errorprone.bugpatterns.threadsafety.ImmutableChecker.matchClass(ImmutableChecker.java:225)
Error:    	at com.google.errorprone.scanner.ErrorProneScanner.processMatchers(ErrorProneScanner.java:450)
Error:    	at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:548)
Error:    	at com.google.errorprone.scanner.ErrorProneScanner.visitClass(ErrorProneScanner.java:151)
Error:    	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:840)
Error:    	at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:86)

openjdk/jdk@657f103 replaces com.sun.tools.javac.util.Filter with Predicate, we may need to wrap the methods in Scope to be compatible with both 17 and previous versions.

I think this affects at least

com/google/errorprone/util/FindIdentifiers
com/google/errorprone/util/ASTHelpers
com/google/errorprone/bugpatterns/ObjectToString
com/google/errorprone/bugpatterns/UnsafeFinalization
com/google/errorprone/bugpatterns/RestrictedApiChecker
com/google/errorprone/bugpatterns/time/PreferJavaTimeOverload
com/google/errorprone/bugpatterns/JavaLangClash
com/google/errorprone/bugpatterns/threadsafety/ImmutableAnalysis
com/google/errorprone/bugpatterns/UnnecessaryMethodReference

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions