Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/error-prone
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.40.0
Choose a base ref
...
head repository: google/error-prone
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.41.0
Choose a head ref
  • 19 commits
  • 41 files changed
  • 4 contributors

Commits on Jul 9, 2025

  1. Update ci.yml

    @cushon
    cushon authored Jul 9, 2025
    Configuration menu
    Copy the full SHA
    6708b63 View commit details
    Browse the repository at this point in the history

  2. Remove distributionManagement from Error Prone pom 

    And instead use the default server id (central) with a corresponding update in https://github.com/google/error-prone/blob/8d324f10754e56ef951a58a9161a1129855cc2bb/.github/workflows/ci.yml#L117

PiperOrigin-RevId: 781157328
    @cushon
    cushon authored and Error Prone Team committed Jul 9, 2025
    Configuration menu
    Copy the full SHA
    f4074b0 View commit details
    Browse the repository at this point in the history

  3. Update[] 

    PiperOrigin-RevId: 781169188
    @cushon
    cushon authored and Error Prone Team committed Jul 9, 2025
    Configuration menu
    Copy the full SHA
    c2e1cc8 View commit details
    Browse the repository at this point in the history

  4. Configure centralSnapshotsUrl 

    PiperOrigin-RevId: 781171483
    @cushon
    cushon authored and Error Prone Team committed Jul 9, 2025
    Configuration menu
    Copy the full SHA
    aceac14 View commit details
    Browse the repository at this point in the history

  5. Update ci.yml

    @cushon
    cushon authored Jul 9, 2025
    Configuration menu
    Copy the full SHA
    319dc7c View commit details
    Browse the repository at this point in the history

  6. Restore distributionManagement 

    PiperOrigin-RevId: 781184586
    @cushon
    cushon authored and Error Prone Team committed Jul 9, 2025
    Configuration menu
    Copy the full SHA
    d50e4b1 View commit details
    Browse the repository at this point in the history

  7. Be slightly more specific that the main issue for SelfAssertion is in… 

    … Truth.

PiperOrigin-RevId: 781199324
    @graememorgan
    graememorgan authored and Error Prone Team committed Jul 9, 2025
    Configuration menu
    Copy the full SHA
    b7f3f1a View commit details
    Browse the repository at this point in the history

  8. Fix a bug in Switches which assumes the CaseTree is of RULE type. 

    You can have `STATEMENT` switches in switch expressions. I didn't know that, and am horrified.

Fixes external #5122.

PiperOrigin-RevId: 781200449
    @graememorgan
    graememorgan authored and Error Prone Team committed Jul 9, 2025
    Configuration menu
    Copy the full SHA
    ccc85f9 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2025

  1. Update reference to snapshot repository 

    PiperOrigin-RevId: 781274720
    @cushon
    cushon authored and Error Prone Team committed Jul 10, 2025
    Configuration menu
    Copy the full SHA
    6d5345d View commit details
    Browse the repository at this point in the history

  2. Add a test confirming external #5151. 

    This seems completely consistent with JLS, but I was pretty surprised by it.

I feel like we could, in general, expand our definition of "constant" to include effectively final variables if we had the motivation to do so, and fancied writing something elaborate to track them.

PiperOrigin-RevId: 781521689
    @graememorgan
    graememorgan authored and Error Prone Team committed Jul 10, 2025
    Configuration menu
    Copy the full SHA
    b5c6175 View commit details
    Browse the repository at this point in the history

  3. TruthIncompatibleType support for MultisetSubject#hasCount. 

    I propose not flagging this given the spectacularly small number of uses _at all_.

PiperOrigin-RevId: 781583086
    @graememorgan
    graememorgan authored and Error Prone Team committed Jul 10, 2025
    Configuration menu
    Copy the full SHA
    3d7b585 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2025

  1. UnnecessaryQualifier: don't fire on interfaces, in deference to Dag… 

    …ger.

I don't think this is ironclad (abstract classes too, perhaps?) but this is probably good enough to avoid obvious Dagger-related false positives.

PiperOrigin-RevId: 782968953
    @graememorgan
    graememorgan authored and Error Prone Team committed Jul 14, 2025
    Configuration menu
    Copy the full SHA
    ef5073b View commit details
    Browse the repository at this point in the history

  2. Recognise com.google.common.inject.components.OtherRequiredBindings… 

    … as an injection method in UnnecessaryQualifier.

This causes a few suppressions in the depot.

PiperOrigin-RevId: 783020383
    @graememorgan
    graememorgan authored and Error Prone Team committed Jul 14, 2025
    Configuration menu
    Copy the full SHA
    43759cd View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2025

  1. Detect non-private, non-override methods in anonymous classes 

    #5156

PiperOrigin-RevId: 783488629
    @cushon
    cushon authored and Error Prone Team committed Jul 15, 2025
    Configuration menu
    Copy the full SHA
    ce784a9 View commit details
    Browse the repository at this point in the history

  2. Fix a println statement left over from ce784a9 

    PiperOrigin-RevId: 783520994
    @cushon
    cushon authored and Error Prone Team committed Jul 15, 2025
    Configuration menu
    Copy the full SHA
    ef33eee View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2025

  1. Refactor to use WellKnownKeep 

    Follow-up to ce784a9

PiperOrigin-RevId: 784222619
    @cushon
    cushon authored and Error Prone Team committed Jul 17, 2025
    Configuration menu
    Copy the full SHA
    13d46e7 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2025

  1. Avoid touching parameters of @Subscribe methods. 

    PiperOrigin-RevId: 784640014
    @cpovirk
    cpovirk authored and Error Prone Team committed Jul 18, 2025
    Configuration menu
    Copy the full SHA
    98d83bf View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2025

  1. Skip BooleanLiteral findings if the target type is boxed 

    PiperOrigin-RevId: 785892169
    @cushon
    cushon authored and Error Prone Team committed Jul 22, 2025
    Configuration menu
    Copy the full SHA
    6161d4e View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2025

  1. Release Error Prone 2.41.0

    @cushon
    cushon committed Jul 24, 2025
    Configuration menu
    Copy the full SHA
    d6539d6 View commit details
    Browse the repository at this point in the history
Loading