Add the interface types for mutable protos so the object hierarchy can diverge as it converges with Immutable Builders.

java-team-github-bot · Error Prone Team · commit d3fc5f3d5fd4 · 2024-07-16T08:35:44.000-07:00
This should have zero impact because `AbstractMutableMessageLite implements MutableMessageLite`.

#checkreturnvalue

PiperOrigin-RevId: 652856389
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/checkreturnvalue/ProtoRules.java b/core/src/main/java/com/google/errorprone/bugpatterns/checkreturnvalue/ProtoRules.java
@@ -50,7 +50,7 @@ public static ResultUseRule<VisitorState, Symbol> protoBuilders() {
    */
   public static ResultUseRule<VisitorState, Symbol> mutableProtos() {
     return new ProtoRule(
-        isDescendantOfAny(ImmutableSet.of("com.google.protobuf.AbstractMutableMessageLite")),
+        isDescendantOfAny(ImmutableSet.of("com.google.protobuf.MutableMessageLite")),
         "MUTABLE_PROTO");
   }
 

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public static ResultUseRule<VisitorState, Symbol> protoBuilders() {`
`50`	`50`	`*/`
`51`	`51`	`public static ResultUseRule<VisitorState, Symbol> mutableProtos() {`
`52`	`52`	`return new ProtoRule(`
`53`		`- isDescendantOfAny(ImmutableSet.of("com.google.protobuf.AbstractMutableMessageLite")),`
	`53`	`+ isDescendantOfAny(ImmutableSet.of("com.google.protobuf.MutableMessageLite")),`
`54`	`54`	`"MUTABLE_PROTO");`
`55`	`55`	`}`
`56`	`56`