Fix an NPE in SetUnrecognized

cushon · Error Prone Team · commit 81d31274cb5f · 2024-07-17T13:18:08.000-07:00
Fixes #4475 PiperOrigin-RevId: 653339273
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/SetUnrecognized.java b/core/src/main/java/com/google/errorprone/bugpatterns/SetUnrecognized.java
@@ -50,6 +50,9 @@ public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState
     }
     ExpressionTree arg = tree.getArguments().get(0);
     var argSymbol = getSymbol(arg);
+    if (argSymbol == null) {
+      return NO_MATCH;
+    }
     if (!argSymbol.getSimpleName().contentEquals("UNRECOGNIZED")) {
       return NO_MATCH;
     }
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/SetUnrecognizedTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/SetUnrecognizedTest.java
@@ -56,4 +56,19 @@ public void negative() {
             "}")
         .doTest();
   }
+
+  @Test
+  public void negativeNotEnum() {
+    compilationHelper
+        .addSourceLines(
+            "Test.java",
+            "import com.google.errorprone.bugpatterns.proto.Proto3Test.TestProto3Enum;",
+            "import com.google.errorprone.bugpatterns.proto.Proto3Test.TestProto3Message;",
+            "class Test {",
+            "  void test() {",
+            "    TestProto3Message.newBuilder().setMyString(\"\");",
+            "  }",
+            "}")
+        .doTest();
+  }
 }

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,9 @@ public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState`
`50`	`50`	`}`
`51`	`51`	`ExpressionTree arg = tree.getArguments().get(0);`
`52`	`52`	`var argSymbol = getSymbol(arg);`
	`53`	`+ if (argSymbol == null) {`
	`54`	`+ return NO_MATCH;`
	`55`	`+ }`
`53`	`56`	`if (!argSymbol.getSimpleName().contentEquals("UNRECOGNIZED")) {`
`54`	`57`	`return NO_MATCH;`
`55`	`58`	`}`