Don't complain about unused variables named _

cushon · Error Prone Team · commit 6bd568d41869 · 2024-07-16T10:54:44.000-07:00
See https://openjdk.org/jeps/456 Fixes #4451 PiperOrigin-RevId: 652904059
diff --git a/check_api/src/main/java/com/google/errorprone/util/RuntimeVersion.java b/check_api/src/main/java/com/google/errorprone/util/RuntimeVersion.java
@@ -79,6 +79,11 @@ public static boolean isAtLeast21() {
     return FEATURE >= 21;
   }
 
+  /** Returns true if the current runtime is JDK 22 or newer. */
+  public static boolean isAtLeast22() {
+    return FEATURE >= 22;
+  }
+
   /**
    * Returns the latest {@code --release} version.
    *
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/UnusedVariable.java b/core/src/main/java/com/google/errorprone/bugpatterns/UnusedVariable.java
@@ -198,6 +198,7 @@ public final class UnusedVariable extends BugChecker implements CompilationUnitT
     this.exemptNames =
         ImmutableSet.<String>builder()
             .add("ignored")
+            .add("") // `var _ = ...` is handled as an empty variable name
             .addAll(flags.getListOrEmpty("Unused:exemptNames"))
             .build();
 
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/UnusedVariableTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/UnusedVariableTest.java
@@ -1679,4 +1679,19 @@ public void parameterUsedInOverride() {
         .expectUnchanged()
         .doTest();
   }
+
+  @Test
+  public void underscoreVariable() {
+    assumeTrue(RuntimeVersion.isAtLeast22());
+    refactoringHelper
+        .addInputLines(
+            "Test.java",
+            "class Test {",
+            "  public static void main(String[] args) {",
+            "    var _ = new Object();",
+            "  }",
+            "}")
+        .expectUnchanged()
+        .doTest();
+  }
 }

Original file line number	Diff line number	Diff line change
`@@ -79,6 +79,11 @@ public static boolean isAtLeast21() {`
`79`	`79`	`return FEATURE >= 21;`
`80`	`80`	`}`
`81`	`81`
	`82`	`+ /** Returns true if the current runtime is JDK 22 or newer. */`
	`83`	`+ public static boolean isAtLeast22() {`
	`84`	`+ return FEATURE >= 22;`
	`85`	`+ }`
	`86`	`+`
`82`	`87`	`/**`
`83`	`88`	`* Returns the latest {@code --release} version.`
`84`	`89`	`*`