Remove an obsolete use of reflection

cushon · Error Prone Team · commit 344e3dcb6038 · 2025-10-20T22:45:57.000-07:00
This worked around a change in JDK 16 (https://bugs.openjdk.org/browse/JDK-8254073) PiperOrigin-RevId: 821956420
diff --git a/check_api/src/main/java/com/google/errorprone/util/ErrorProneTokens.java b/check_api/src/main/java/com/google/errorprone/util/ErrorProneTokens.java
@@ -113,7 +113,7 @@ public Map<Comment, ErrorProneComment> comments() {
 
     @Override
     protected Comment processComment(int pos, int endPos, CommentStyle style) {
-      char[] buf = getRawCharactersReflectively(pos, endPos);
+      char[] buf = getRawCharacters(pos, endPos);
       Comment comment = super.processComment(pos, endPos, style);
       AccessibleReader reader = new AccessibleReader(fac, buf, buf.length);
       ErrorProneComment errorProneComment =
@@ -126,24 +126,6 @@ protected Comment processComment(int pos, int endPos, CommentStyle style) {
       comments.put(comment, errorProneComment);
       return comment;
     }
-
-    private char[] getRawCharactersReflectively(int beginIndex, int endIndex) {
-      Object instance;
-      try {
-        instance = JavaTokenizer.class.getDeclaredField("reader").get(this);
-      } catch (ReflectiveOperationException e) {
-        instance = this;
-      }
-      try {
-        return (char[])
-            instance
-                .getClass()
-                .getMethod("getRawCharacters", int.class, int.class)
-                .invoke(instance, beginIndex, endIndex);
-      } catch (ReflectiveOperationException e) {
-        throw new LinkageError(e.getMessage(), e);
-      }
-    }
   }
 
   // Scanner(ScannerFactory, JavaTokenizer) is package-private
