Fix handling of foo.new A() {}.

graememorgan · Error Prone Team · commit 2d20166823b2 · 2022-04-14T12:27:37.000-07:00
This is awful.

PiperOrigin-RevId: 441825465
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessarilyFullyQualified.java b/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessarilyFullyQualified.java
@@ -20,6 +20,7 @@
 import static com.google.errorprone.util.ASTHelpers.getGeneratedBy;
 import static com.google.errorprone.util.ASTHelpers.getSymbol;
 import static com.google.errorprone.util.ASTHelpers.getType;
+import static com.google.errorprone.util.ASTHelpers.isGeneratedConstructor;
 import static com.google.errorprone.util.FindIdentifiers.findIdent;
 import static com.sun.tools.javac.code.Kinds.KindSelector.VAL_TYP;
 import static java.util.stream.Collectors.toCollection;
@@ -37,10 +38,12 @@
 import com.google.errorprone.fixes.SuggestedFix;
 import com.google.errorprone.matchers.Description;
 import com.google.errorprone.util.ASTHelpers;
+import com.sun.source.tree.ClassTree;
 import com.sun.source.tree.CompilationUnitTree;
 import com.sun.source.tree.IdentifierTree;
 import com.sun.source.tree.ImportTree;
 import com.sun.source.tree.MemberSelectTree;
+import com.sun.source.tree.MethodTree;
 import com.sun.source.tree.Tree;
 import com.sun.source.util.SimpleTreeVisitor;
 import com.sun.source.util.TreePath;
@@ -86,6 +89,25 @@ public Void visitImport(ImportTree importTree, Void unused) {
         return null;
       }
 
+      @Override
+      public Void visitClass(ClassTree tree, Void unused) {
+        scan(tree.getModifiers(), null);
+        scan(tree.getTypeParameters(), null);
+        // Some anonymous classes have an extends clause which is fully qualified. Just ignore it.
+        if (!getSymbol(tree).isAnonymous()) {
+          scan(tree.getExtendsClause(), null);
+          scan(tree.getImplementsClause(), null);
+        }
+        scan(tree.getMembers(), null);
+        return null;
+      }
+
+      @Override
+      public Void visitMethod(MethodTree tree, Void unused) {
+        // Some generated constructors sneak in a fully qualified argument.
+        return isGeneratedConstructor(tree) ? null : super.visitMethod(tree, null);
+      }
+
       @Override
       public Void visitMemberSelect(MemberSelectTree memberSelectTree, Void unused) {
         if (!shouldIgnore()) {
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/UnnecessarilyFullyQualifiedTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/UnnecessarilyFullyQualifiedTest.java
@@ -195,6 +195,22 @@ public void exemptedNames() {
         .doTest();
   }
 
+  @Test
+  public void innerClass() {
+    helper
+        .addInputLines(
+            "A.java", //
+            "package test;",
+            "public class A {",
+            "  class B {}",
+            "  void test (A a) {",
+            "    a.new B() {};",
+            "  }",
+            "}")
+        .expectUnchanged()
+        .doTest();
+  }
+
   @Test
   public void packageInfo() {
     CompilationTestHelper.newInstance(UnnecessarilyFullyQualified.class, getClass())
