Add _ITERATOR_DEBUG_LEVEL=2 and _DEBUG defines #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
LGTM. |
floitsch
approved these changes
Jul 11, 2023
3 tasks
floitsch
pushed a commit
that referenced
this pull request
Oct 4, 2025
This reverts commit dfa08c4. The original change is invalid. `_ITERATOR_DEBUG_LEVEL=2` is the default value in debug builds. And now it's impossible to override it because it's *appended* to `CMAKE_CXX_FLAGS_DEBUG`. I suspect that the original problem was that release double-conversion library was used in debug builds of Qt. This is not something that should be fixed in double-conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the _ITERATOR_DEBUG_LEVEL flag is not set for Debug builds. This causes mismatch errors when attempting to build consuming codebases where this flag is set.
I have personally run in to this issue when attempting to build Qt 5.15.2.
My change appends
_ITERATOR_DEBUG_LEVEL=2and_DEBUGto theCMAKE_CXX_FLAGS_DEBUGvariable, allowing the values to appear in the preprocessor list in the generated .vcxproj file (debug only). The flags have also been manually added to the existing .vcxproj file, in themsvc/directory.