Fix some compile warnings in Visual Studio #188
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thanks for the pull request. |
floitsch
left a comment
floitsch
left a comment
There was a problem hiding this comment.
Thanks.
Looks good after the changes.
double-conversion/bignum.cc
Outdated
| if (tmp > 0) { | ||
| DOUBLE_CONVERSION_ASSERT(tmp <= kBigitMask); | ||
| RawBigit(used_bigits_++) = (tmp & kBigitMask); | ||
| RawBigit(used_bigits_++) = (Bignum::Chunk)(tmp & kBigitMask); |
There was a problem hiding this comment.
Please change to C++ static_cast<Bignum::Chunk> casts. Here and for the others.
double-conversion/bignum.cc.patch
Outdated
| @@ -0,0 +1,51 @@ | |||
| Index: bignum.cc | |||
|
Thanks for the PR. |
2 participants
These are some changes I made to get double-conversion to compile without warnings in Visual Studio 2012.
I had to manually make the changes for this pull request, code is not tested! (my local double-conversion is slightly different and in SVN)