Skip to content

Conversation

@cdluminate
Copy link
Contributor

Please refer to https://en.wikipedia.org/wiki/NaN, the MIPS* and PA-RISC
(also known as HPPA) architectures regard the "is_quiet/is_signaling" bit
the reversed way compared to other architectures.

This patch fixes #171

Please refer to https://en.wikipedia.org/wiki/NaN, the MIPS* and PA-RISC
(also known as HPPA) architectures regard the "is_quiet/is_signaling" bit
the reversed way compared to other architectures.

This patch fixes #171
@cdluminate
Copy link
Contributor Author

I've uploaded the patch to Debian. The build result seems good enough: https://buildd.debian.org/status/package.php?p=double%2dconversion

Failures on mips* and hppa are fixed by this patch.

Copy link
Collaborator

@floitsch floitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@floitsch floitsch merged commit 03c48d6 into google:master Jan 10, 2022
@floitsch
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] ieee.h: Wrong QuietNaN bit check on mips* architectures

2 participants