Merged
Conversation
This was referenced Apr 25, 2024
deining
approved these changes
Apr 26, 2024
Contributor
deining
left a comment
deining
left a comment
There was a problem hiding this comment.
Just checked this simplification on an existing site that caused problems in the past and it worked well, so LGTM.
tobiaskohlbau
approved these changes
Apr 26, 2024
Contributor
tobiaskohlbau
left a comment
tobiaskohlbau
left a comment
There was a problem hiding this comment.
Sorry for the late response in my PR was quite busy the last couple of days. Checked out this PR and tested it. Works like expected for the site having issuers earlier.
chalin
force-pushed
the
chalin-im-section-index-2024-04-25
branch
from
7ad3577 to
2348b53
Compare
Collaborator
Author
|
Thanks all for your reviews and feedback. Btw, I don't like having two variables that differ only in one character, such as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$parentto$page$parent.File.UniqueIDusing Hugo 0.123.1. #1874/cc @yann-soubeyrand @tobiaskohlbau @chulcher @marshalc