Skip to content

Comments

Fix warning: '.File.UniqueID on zero object' (#1007)#1633

Merged
chalin merged 1 commit intogoogle:mainfrom
deining:file-unique-zero-object
Jan 19, 2024
Merged

Fix warning: '.File.UniqueID on zero object' (#1007)#1633
chalin merged 1 commit intogoogle:mainfrom
deining:file-unique-zero-object

Conversation

@deining
Copy link
Contributor

@deining deining commented Jul 29, 2023

This PR closes #1007 (see my analysis there). The fix is quite easy, all we have to do here is to put a {{ with }} statement around the offending code line 8:

7  {{ with .Parent.File -}}
8     {{ $pages = (where $pages "Parent.File.UniqueID" "==" $parent.File.UniqueID) -}}
9  {{ end -}}

Also I did some code cleanup in order to prevent superfluous whitespace and lines.
I did a diff of the published user guide, and there are no changes caused by this PR other than white space cleanup.

@deining deining requested a review from chalin July 29, 2023 08:47
@deining deining added cleanup/refactoring e0-minutes Effort < 60 min fix Resolves some issue in the current code base labels Jul 29, 2023
@deining deining added this to the 23Q4 milestone Nov 4, 2023
@deining deining force-pushed the file-unique-zero-object branch from b7b9d02 to b8d0b97 Compare November 19, 2023 16:54
@deining deining force-pushed the file-unique-zero-object branch from b8d0b97 to 3f112d2 Compare December 31, 2023 15:39
@chalin chalin modified the milestones: 23Q4, 24Q1 Jan 11, 2024
@chalin chalin force-pushed the file-unique-zero-object branch from 3f112d2 to 9b1aa28 Compare January 15, 2024 22:42
chalin
chalin approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you! See inline comment for one nit.

@chalin
Copy link
Collaborator

chalin commented Jan 15, 2024

The test failure is due to a flaky external link check (which should be fixed via #1790).

@deining deining force-pushed the file-unique-zero-object branch from 9b1aa28 to 821d336 Compare January 16, 2024 06:22
@deining deining requested a review from chalin January 16, 2024 06:23
@chalin chalin merged commit 96baa45 into google:main Jan 19, 2024
@deining deining deleted the file-unique-zero-object branch January 19, 2024 20:05
@chulcher chulcher mentioned this pull request Feb 15, 2024
Closed
12 tasks
@chalin chalin mentioned this pull request Feb 15, 2024
Merged
dbreseman added a commit to mendix/docs that referenced this pull request Feb 20, 2024
@dbreseman
Fix warning: '.File.UniqueID on zero object'
2877248 
See google/docsy#1633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chalin chalin chalin approved these changes

Assignees

No one assigned

Labels

cleanup/refactoring e0-minutes Effort < 60 min fix Resolves some issue in the current code base

Projects

None yet

Milestone

24Q1

Development

Successfully merging this pull request may close these issues.

hugo build: warning '.File.UniqueID on zero object'

2 participants

@deining @chalin