Remove private from generated Factory's INSTANCE field.#4547
Merged
copybara-service[bot] merged 1 commit intomasterfrom Dec 20, 2024
Merged
Remove private from generated Factory's INSTANCE field.#4547copybara-service[bot] merged 1 commit intomasterfrom
copybara-service[bot] merged 1 commit intomasterfrom
Conversation
Fixes #4544 Background: Dagger's generated factory has an optimization to lazy load a singleton instance of the factory when there are no dependencies: ``` public final class Foo_Factory implements Factory<Foo> { public static Foo_Factory create() { return InstanceHolder.INSTANCE; } private static final class InstanceHolder { private static final Foo_Factory INSTANCE = new Foo_Factory(); } } ``` The `private` modifier on the `INSTANCE` field is not needed and can add extra overhead as described in #4544. Removing the `private` modifier is also needed once we start generating Kotlin sources since accessing a `private` field on a nested class in kotlin source is a kotlinc error. RELNOTES=Fixes #4544: Removes private from InstanceHolder field. PiperOrigin-RevId: 708101532
c1e3c39 to
07d8f88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove private from generated Factory's INSTANCE field.
Fixes #4544
Background: Dagger's generated factory has an optimization to lazy load a singleton instance of the factory when there are no dependencies:
The
privatemodifier on theINSTANCEfield is not needed and can add extra overhead as described in #4544. Removing theprivatemodifier is also needed once we start generating Kotlin sources since accessing aprivatefield on a nested class in kotlin source is a kotlinc error.RELNOTES=Fixes #4544: Removes private from InstanceHolder field.