Conversation
…at multibindings contributions bound in a parent component cannot access bindings from child components. This fixes other bugs that may result from this unintentionally previously supported behavior. This flag is default off but will become the default in the future. RELNOTES=Add -Adagger.strictMultibindingValidation to fix multibinding contributions that depend on subcomponent bindings. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=329382961
…onent dependencies See #970 Fixes #970 RELNOTES=Fix #970: Add a compiler option to prevent validating transitive component dependencies. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=329394738
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.
Commits:
Add a flag -Adagger.strictMultibindingValidation that will enforce that multibindings contributions bound in a parent component cannot access bindings from child components. This fixes other bugs that may result from this unintentionally previously supported behavior. This flag is default off but will become the default in the future.
RELNOTES=Add -Adagger.strictMultibindingValidation to fix multibinding contributions that depend on subcomponent bindings.
b0c1f1f
[Dagger]: Add a compiler option to prevent validating transitive component dependencies
See #970
Fixes #970
RELNOTES=Fix #970: Add a compiler option to prevent validating transitive component dependencies.
9959c72