Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/dagger
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: dagger-2.59
Choose a base ref
...
head repository: google/dagger
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dagger-2.59.1
Choose a head ref
  • 14 commits
  • 76 files changed
  • 6 contributors

Commits on Jan 21, 2026

  1. Update Dagger yml and README with new latest version number.

    RELNOTES=N/A
    PiperOrigin-RevId: 859216913
    bcorso authored and Dagger Team committed Jan 21, 2026
    1 Configuration menu
    Copy the full SHA
    7ac5c33 View commit details
    Browse the repository at this point in the history
  2. Set shell for new action from 6eb10d1.

    This [should](https://stackoverflow.com/a/71042698/28465) fix [the new error](https://github.com/google/dagger/actions/runs/21182139061/job/60927598068):
    
    ```
    Error: /home/runner/work/dagger/dagger/./.github/actions/artifact-android-emulator-tests/action.yml (Line: 13, Col: 7): Required property is missing: shell
    Error: GitHub.DistributedTask.ObjectTemplating.TemplateValidationException: The template is not valid. /home/runner/work/dagger/dagger/./.github/actions/artifact-android-emulator-tests/action.yml (Line: 13, Col: 7): Required property is missing: shell
    ```
    RELNOTES=n/a
    PiperOrigin-RevId: 859258952
    cpovirk authored and Dagger Team committed Jan 21, 2026
    Configuration menu
    Copy the full SHA
    69a7e95 View commit details
    Browse the repository at this point in the history
  3. Internal changes

    RELNOTES=N/A
    PiperOrigin-RevId: 859262559
    bcorso authored and Dagger Team committed Jan 21, 2026
    Configuration menu
    Copy the full SHA
    d5efe51 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2026

  1. Remove ancient libs entry from .gitignore.

    This entry comes from all the way back in d2858b5.
    
    It might reflect that Dagger once contained a directory of prebuilt dependencies, but I think it's more likely to come been from some default/recommended list of ignore patterns.
    
    Nowadays, it causes us to ignore a few directories that we probably don't want to ignore:
    
    ```
    ./javatests/artifacts/hilt-android/simpleKotlin/android-library/src/main/java/dagger/hilt/android/simpleKotlin/lib:
    AndroidLibraryEntryPoints.kt
    
    ./javatests/artifacts/hilt-android/simpleKotlin/kotlin-library/src/main/java/dagger/hilt/android/simpleKotlin/lib:
    KotlinLibraryEntryPoints.kt
    
    ./javatests/artifacts/hilt-android/simple/lib:
    build  build.gradle  src
    
    ./javatests/artifacts/hilt-android/simple/lib/src/main/java/dagger/hilt/android/simple/lib:
    ThingImpl.java  Thing.java
    ```
    
    I'm getting the sense that this might not matter much because Copybara adds files manually? But it could matter to an external contributor, and it appears to matter to the Gemini CLI, whose `ReadFile` operation had trouble reading a file in one of the `lib` directories...
    
    ```
    File path '/usr/local/google/home/cpovirk/clients/dagger-yellow/dagger/javatests/artifacts/hilt-android/simple/lib/build.gradle' is ignored by configured ignore patterns.
    ```
    
    ...though Gemini worked around it by using `cat` :)
    
    RELNOTES=n/a
    PiperOrigin-RevId: 859756539
    cpovirk authored and Dagger Team committed Jan 22, 2026
    Configuration menu
    Copy the full SHA
    213ff97 View commit details
    Browse the repository at this point in the history
  2. Fix emulator tests.

    I see success, at least in the one time I tried after my final fix: [23](https://github.com/google/dagger/actions/runs/21265421466/job/61203969922?pr=5100), [26](https://github.com/google/dagger/actions/runs/21265421466/job/61203969919?pr=5100), [30](https://github.com/google/dagger/actions/runs/21265421466/job/61203969910?pr=5100).
    
    Those each took around 15 minutes or more, so that's probably slower than the ~13m on [the Hilt job](https://github.com/google/dagger/actions/runs/21265421466/job/61203969888?pr=5100). So it presumably makes sense to keep the emulator tests running only after merges to `master`, rather than running them on pull requests, even if we charitably assume that my fix will keep them working reliably.
    
    ### Set `AGP_VERSION`
    
    That fixes [this error](https://github.com/google/dagger/actions/runs/21227691196/job/61079454578#step:3:466):
    
    ```
    > Could not resolve all artifacts for configuration 'classpath'.
       > Could not find com.android.tools.build:gradle:null.
         Searched in the following locations:
           - https://dl.google.com/dl/android/maven2/com/android/tools/build/gradle/null/gradle-null.pom
           - https://repo.maven.apache.org/maven2/com/android/tools/build/gradle/null/gradle-null.pom
           - file:/home/runner/.m2/repository/com/android/tools/build/gradle/null/gradle-null.pom
         Required by:
             buildscript of root project 'Simple Hilt Android'
       > Could not find com.android.legacy-kapt:com.android.legacy-kapt.gradle.plugin:null.
         Searched in the following locations:
           - https://dl.google.com/dl/android/maven2/com/android/legacy-kapt/com.android.legacy-kapt.gradle.plugin/null/com.android.legacy-kapt.gradle.plugin-null.pom
           - https://repo.maven.apache.org/maven2/com/android/legacy-kapt/com.android.legacy-kapt.gradle.plugin/null/com.android.legacy-kapt.gradle.plugin-null.pom
           - file:/home/runner/.m2/repository/com/android/legacy-kapt/com.android.legacy-kapt.gradle.plugin/null/com.android.legacy-kapt.gradle.plugin-null.pom
         Required by:
             buildscript of root project 'Simple Hilt Android'
    ```
    
    ### Fix `sourceSets` configuration
    
    That fixes [this error](https://github.com/google/dagger/actions/runs/21261143612/job/61189377362#step:3:760):
    
    ```
    error: [Hilt] Type <error> not present: java.lang.TypeNotPresentException: Type <error> not present
      	at dagger.spi.internal.shaded.androidx.room3.compiler.processing.javac.JavacAnnotationValueKt$UNWRAP_VISITOR$1.visitString(JavacAnnotationValue.kt:72)
      	at dagger.spi.internal.shaded.androidx.room3.compiler.processing.javac.JavacAnnotationValueKt$UNWRAP_VISITOR$1.visitString(JavacAnnotationValue.kt:53)
      	at jdk.compiler/com.sun.tools.javac.code.Attribute$Error.accept(Attribute.java:397)
      	at [email protected]/javax.lang.model.util.AbstractAnnotationValueVisitor6.visit(AbstractAnnotationValueVisitor6.java:90)
      	at dagger.spi.internal.shaded.androidx.room3.compiler.processing.javac.JavacAnnotationValue._init_$lambda$0(JavacAnnotationValue.kt:38)
      	at dagger.spi.internal.shaded.androidx.room3.compiler.processing.javac.JavacAnnotationValue.value_delegate$lambda$0(JavacAnnotationValue.kt:47)
      	at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:86)
      	at dagger.spi.internal.shaded.androidx.room3.compiler.processing.javac.JavacAnnotationValue.getValue(JavacAnnotationValue.kt:47)
      	at dagger.spi.internal.shaded.androidx.room3.compiler.processing.XAnnotationValue.asType(XAnnotationValue.kt:60)
      	at dagger.spi.internal.shaded.androidx.room3.compiler.processing.XAnnotation.getAsType(XAnnotation.kt:75)
      	at dagger.hilt.android.processor.internal.customtestapplication.CustomTestApplicationMetadata.getBaseElement(CustomTestApplicationMetadata.java:73)
      	at dagger.hilt.android.processor.internal.customtestapplication.CustomTestApplicationMetadata.of(CustomTestApplicationMetadata.java:64)
      	at dagger.hilt.android.processor.internal.customtestapplication.CustomTestApplicationProcessingStep.processEach(CustomTestApplicationProcessingStep.java:40)
      	at dagger.hilt.processor.internal.BaseProcessingStep.process(BaseProcessingStep.java:116)
      	at dagger.hilt.android.processor.internal.customtestapplication.CustomTestApplicationProcessingStep.process(CustomTestApplicationProcessingStep.java:27)
      	at dagger.spi.internal.shaded.androidx.room3.compiler.processing.CommonProcessorDelegate.processRound(XBasicAnnotationProcessor.kt:134)
      	at dagger.spi.internal.shaded.androidx.room3.compiler.processing.javac.JavacBasicAnnotationProcessor.process(JavacBasicAnnotationProcessor.kt:75)
        ...
      [Hilt] Processing did not complete. See error above for details.
    /home/runner/work/dagger/dagger/javatests/artifacts/hilt-android/simple/app/src/androidTest/java/dagger/hilt/android/simple/CustomTestApplicationTest.java:24: error: package dagger.hilt.android.simple.BaseTestApplication does not exist
    import dagger.hilt.android.simple.BaseTestApplication.Foo;
                                                         ^
    /home/runner/work/dagger/dagger/javatests/artifacts/hilt-android/simple/app/src/androidTest/java/dagger/hilt/android/simple/SimpleEmulatorTestRunner.java:25: error: cannot find symbol
    @CustomTestApplication(BaseTestApplication.class)
                           ^
      symbol: class BaseTestApplication
    3 errors
    ```
    
    ### Add `androidx.test:runner` deps
    
    That fixes [this error](https://github.com/google/dagger/actions/runs/21261773438/job/61191426719?pr=5100#step:3:1289):
    
    ```
    java.lang.RuntimeException: Unable to instantiate instrumentation ComponentInfo{dagger.hilt.android.simple.feature.test/androidx.test.runner.AndroidJUnitRunner}: java.lang.ClassNotFoundException: Didn't find class "androidx.test.runner.AndroidJUnitRunner" on path: DexPathList[[zip file "/data/app/~~29WTUxCgOzLabNLQzJ8kYg==/dagger.hilt.android.simple.feature.test-tzT2A65wdeKUNb9A4DoDzA==/base.apk"],nativeLibraryDirectories=[/data/app/~~29WTUxCgOzLabNLQzJ8kYg==/dagger.hilt.android.simple.feature.test-tzT2A65wdeKUNb9A4DoDzA==/lib/x86, /system/lib, /system_ext/lib]]
    ```
    
    ### Make Proguard keep more Kotlin APIs
    
    That fixes [this error](https://github.com/google/dagger/actions/runs/21263645032/job/61197804944#step:3:2455):
    
    ```
    java.lang.NoSuchMethodError: No direct method <init>(I)V in class Lkotlin/jvm/internal/Lambda; or its super classes (declaration of 'kotlin.jvm.internal.Lambda' appears in /data/app/dagger.lazyclasskey-pi80cZHtWbrAHi92wBPzsA==/base.apk)
    	at androidx.test.platform.io.OutputDirCalculator$outputDir$2.<init>(OutputDirCalculator.kt:0)
    	at androidx.test.platform.io.OutputDirCalculator.<init>(OutputDirCalculator.kt:27)
    	at androidx.test.platform.io.FileTestStorage.<init>(FileTestStorage.java:45)
    	at androidx.test.runner.AndroidJUnitRunner.registerTestStorage(AndroidJUnitRunner.java:664)
    	at androidx.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:441)
    	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:2074)
    ```
    
    RELNOTES=n/a
    PiperOrigin-RevId: 859792812
    cpovirk authored and Dagger Team committed Jan 22, 2026
    Configuration menu
    Copy the full SHA
    7a370d9 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2026

  1. Update Bazel module dependencies and remove unnecessary :aar suffixes.

    RELNOTES=Updated Bazel module dependencies
    PiperOrigin-RevId: 859832267
    trexem authored and Dagger Team committed Jan 23, 2026
    Configuration menu
    Copy the full SHA
    e679bd9 View commit details
    Browse the repository at this point in the history
  2. Internal Changes

    RELNOTES=N/A
    PiperOrigin-RevId: 860216698
    trexem authored and Dagger Team committed Jan 23, 2026
    Configuration menu
    Copy the full SHA
    d060e95 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2026

  1. Update minimum required AGP version to 9.0.0.

    RELNOTES=Updated minimum required AGP version to 9.0.0.
    PiperOrigin-RevId: 861736966
    trexem authored and Dagger Team committed Jan 27, 2026
    Configuration menu
    Copy the full SHA
    141e594 View commit details
    Browse the repository at this point in the history
  2. Internal changes

    RELNOTES=N/A
    PiperOrigin-RevId: 861878027
    trexem authored and Dagger Team committed Jan 27, 2026
    Configuration menu
    Copy the full SHA
    f9deeef View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2026

  1. Use java_single_jar instead of a java_binary to roll up deps

    RELNOTES=n/a
    PiperOrigin-RevId: 862338970
    cushon authored and Dagger Team committed Jan 28, 2026
    Configuration menu
    Copy the full SHA
    9354ef3 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2026

  1. Upgrading protobuf-java version to 4.32.1

    Closes #5104
    
    RELNOTES=Updated protobuf-java dependency to 4.32.1
    PiperOrigin-RevId: 863293559
    vijaykriishna authored and Dagger Team committed Jan 30, 2026
    Configuration menu
    Copy the full SHA
    ed252cd View commit details
    Browse the repository at this point in the history
  2. Add AggregatedPackagesTransform for "android-classes" artifact type.

    This change adds a transform for AggregatedPackagesTransform to run on the "android-classes" artifact type. This is necessary when Jetifier is enabled, as AGP transforms AARs into "android-classes" artifacts, which Hilt needs to aggregate.
    FIXES #5099
    
    RELNOTES=Fixed compilation error with jetifier enabled and AGP 9
    PiperOrigin-RevId: 863370571
    trexem authored and Dagger Team committed Jan 30, 2026
    Configuration menu
    Copy the full SHA
    8dcce87 View commit details
    Browse the repository at this point in the history
  3. Internal changes

    RELNOTES=N/A
    PiperOrigin-RevId: 863410555
    bcorso authored and Dagger Team committed Jan 30, 2026
    Configuration menu
    Copy the full SHA
    62b5423 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2026

  1. 2.59.1 release

    Dagger Team
    Dagger Team committed Feb 2, 2026
    Configuration menu
    Copy the full SHA
    45105f9 View commit details
    Browse the repository at this point in the history
Loading