Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/dagger
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: dagger-2.56.1
Choose a base ref
...
head repository: google/dagger
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dagger-2.56.2
Choose a head ref
  • 19 commits
  • 108 files changed
  • 5 contributors

Commits on Mar 25, 2025

  1. Update Dagger yml and README with new latest version number.

    RELNOTES=N/A
    PiperOrigin-RevId: 740488311
    bcorso authored and Dagger Team committed Mar 25, 2025
    Configuration menu
    Copy the full SHA
    515601c View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2025

  1. [XPoet Migration]: Migrate more CodeBlock usages to XCodeBlock.

    RELNOTES=N/A
    PiperOrigin-RevId: 740802635
    bcorso authored and Dagger Team committed Mar 26, 2025
    Configuration menu
    Copy the full SHA
    59a6734 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2025

  1. [XPoet Migration]: Migrate more CodeBlock usages to XCodeBlock.

    RELNOTES=N/A
    PiperOrigin-RevId: 741161983
    bcorso authored and Dagger Team committed Mar 27, 2025
    Configuration menu
    Copy the full SHA
    abc6458 View commit details
    Browse the repository at this point in the history
  2. Internal changes.

    RELNOTES=n/a
    PiperOrigin-RevId: 741219198
    Chang-Eric authored and Dagger Team committed Mar 27, 2025
    Configuration menu
    Copy the full SHA
    c6e37c0 View commit details
    Browse the repository at this point in the history
  3. Remove #delayErrors() from processing step.

    This feature was originally added to allow Hilt to continue processing and potentially generate files that would otherwise show up as missing symbols and potentially pollute the error logs. However, the implementation of this feature doesn't work with KSP2 which will crash if elements are accessed outside of the round they were created. We could work around this issue by storing identifying information about elements (e.g. parameter name -> method signature -> class name) to recreate elements in the current round; but we decided to just remove this feature since it's not clear it has a lot of benefit.
    
    RELNOTES=N/A
    PiperOrigin-RevId: 741279228
    bcorso authored and Dagger Team committed Mar 27, 2025
    Configuration menu
    Copy the full SHA
    6beec64 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2025

  1. Add memoization to BindingGraph#dependencyGraph().

    This method is private, but is called from the public method `BindingGraph#entryPointEdgesDependingOnBinding(MaybeBinding)` and without memoization will create a new (identical) graph each time it's called.
    
    RELNOTES=N/A
    PiperOrigin-RevId: 742410107
    bcorso authored and Dagger Team committed Mar 31, 2025
    Configuration menu
    Copy the full SHA
    292eb6f View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2025

  1. Replace KSP1 usages in Dagger/Hilt compiler tests with KSP2.

    RELNOTES=N/A
    PiperOrigin-RevId: 742453757
    bcorso authored and Dagger Team committed Apr 1, 2025
    Configuration menu
    Copy the full SHA
    da35c51 View commit details
    Browse the repository at this point in the history
  2. Internal change.

    RELNOTES=n/a
    PiperOrigin-RevId: 742852939
    cushon authored and Dagger Team committed Apr 1, 2025
    Configuration menu
    Copy the full SHA
    270cdfd View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2025

  1. [XPoet Migration]: Migrate TypeSpec usages to XTypeSpec.

    This CL also creates a wrapper class for XTypeSpec.Builder, which has a few benefits:
    
      1. Has method overloads for both JavaPoet and XPoet
      2. Has method API that is very similar to JavaPoet
      3. Allows adding in functionality specific to all Dagger generated types (e.g. setting common default values for all of the builders).
    
    The first two benefits are mostly for migration purposes, but my thought is that we'll likely keep these builders around even after the migration because it just makes it easier to customize the API to Dagger's needs.
    
    RELNOTES=N/A
    PiperOrigin-RevId: 743193970
    bcorso authored and Dagger Team committed Apr 2, 2025
    Configuration menu
    Copy the full SHA
    7c4622d View commit details
    Browse the repository at this point in the history
  2. [XPoet Migration]: Migrate remaining TypeSpec to XTypeSpec.

    RELNOTES=N/A
    PiperOrigin-RevId: 743228588
    bcorso authored and Dagger Team committed Apr 2, 2025
    Configuration menu
    Copy the full SHA
    592ff20 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2025

  1. Automated Code Change

    PiperOrigin-RevId: 743682120
    java-team-github-bot authored and Dagger Team committed Apr 3, 2025
    Configuration menu
    Copy the full SHA
    9d2fda1 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2025

  1. [XPoet Migration]: Migrate all MethodSpec to XFunSpec.

    This CL adds a new utility class, `XFunSpecs.java`, which includes a wrapper of `XFunSpec.Builder` to expose an API that's easier for migration. In particular, the wrapper is very similar to JavaPoet's API, and it allows setting input as both JavaPoet and/or XPoet.
    
    The JavaPoet APIs are marked as `@Deprecated` and they will be cleaned up in a future CL.
    
    RELNOTES=N/A
    PiperOrigin-RevId: 745249141
    bcorso authored and Dagger Team committed Apr 8, 2025
    Configuration menu
    Copy the full SHA
    dc3a8b3 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2025

  1. Internal changes

    RELNOTES=N/A
    PiperOrigin-RevId: 745621882
    bcorso authored and Dagger Team committed Apr 9, 2025
    Configuration menu
    Copy the full SHA
    7a92bc8 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2025

  1. Add maven install lock file.

    This was motivated by #4658.
    
    The lock file has [a few benefits](https://github.com/bazel-contrib/rules_jvm_external?tab=readme-ov-file#pinning-artifacts-and-integration-with-bazels-downloader):
    
      * Explicitly keeps track of versions (which might be different than the versions we declare in MODULE.bazel).
      * Verifies artifacts against their checksums
      * Improves caching of external dependencies.
    
    RELNOTES=N/A
    PiperOrigin-RevId: 746316091
    bcorso authored and Dagger Team committed Apr 11, 2025
    Configuration menu
    Copy the full SHA
    b3ba9b3 View commit details
    Browse the repository at this point in the history
  2. Pin Guava to version 33.0.0 specified in MODULE.bazel.

    Fixes #4658
    
    Typically, this shouldn't be an issue because we declared Guava 33.3.1 in [Dagger's pom file](https://repo1.maven.org/maven2/com/google/dagger/dagger-compiler/2.56.1/dagger-compiler-2.56.1.pom), which should force downstream users to get the upgraded dependency. However, a bug in Gradle (https://youtrack.jetbrains.com/issue/KT-76388) is currently pulling in Guava 32.1.2 onto the ClassLoader first resulting in the following error:
    
    ```
    java.lang.NoSuchMethodError: 'com.google.common.collect.ImmutableSet com.google.common.graph.Graphs.reachableNodes(com.google.common.graph.Graph, java.lang.Object)'
    ```
    
    RELNOTES=Fixes #4658: Pin version of Guava to the one specified in our maven.install (i.e. v33.0.0).
    PiperOrigin-RevId: 746529208
    bcorso authored and Dagger Team committed Apr 11, 2025
    Configuration menu
    Copy the full SHA
    9fc3df4 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2025

  1. Disable ad-hoc support for type-use nullability on generated jave typ…

    …e arguments.
    
    Fixes #4676
    
    This feature causes issues for types whose kotlin and java representation have mismatched shapes, e.g. suspend function.
    
    RELNOTES=Fixes #4676: Disable support for type-use nullability on generated jave type arguments.
    PiperOrigin-RevId: 748081674
    bcorso authored and Dagger Team committed Apr 16, 2025
    Configuration menu
    Copy the full SHA
    5d59aed View commit details
    Browse the repository at this point in the history
  2. [XPoet Migration]: Migrate FieldSpec to XPropertySpec.

    This CL adds a new utility class, XPropertySpecs.java, which includes a wrapper of XPropertySpec.Builder to expose an API that's easier for migration. In particular, the wrapper is very similar to JavaPoet's API, and it allows setting input as both JavaPoet and/or XPoet.
    
    The JavaPoet APIs are marked as @deprecated and they will be cleaned up in a future CL.
    
    RELNOTES=N/A
    PiperOrigin-RevId: 748332454
    bcorso authored and Dagger Team committed Apr 16, 2025
    Configuration menu
    Copy the full SHA
    cccec89 View commit details
    Browse the repository at this point in the history
  3. [XPoet Migration]: Migrate ParameterSpec to XParameterSpec.

    RELNOTES=N/A
    PiperOrigin-RevId: 748367336
    bcorso authored and Dagger Team committed Apr 16, 2025
    Configuration menu
    Copy the full SHA
    96e755c View commit details
    Browse the repository at this point in the history
  4. 2.56.2 release

    Dagger Team committed Apr 16, 2025
    Configuration menu
    Copy the full SHA
    cb98d97 View commit details
    Browse the repository at this point in the history
Loading