Close JavaCompiler objects to avoid resource leaks

java-team-github-bot · Compile-Testing Team · commit cd2c0a8b86f0 · 2020-11-03T17:02:42.000-08:00
RELNOTES=Close JavaCompiler objects to avoid resource leaks
PiperOrigin-RevId: 340553115
diff --git a/src/main/java/com/google/testing/compile/Parser.java b/src/main/java/com/google/testing/compile/Parser.java
@@ -34,6 +34,7 @@
 import com.sun.source.util.TreeScanner;
 import com.sun.source.util.Trees;
 import com.sun.tools.javac.api.JavacTool;
+import com.sun.tools.javac.util.Context;
 import java.io.IOException;
 import java.util.List;
 import java.util.Locale;
@@ -56,6 +57,7 @@ static ParseResult parse(Iterable<? extends JavaFileObject> sources) {
     InMemoryJavaFileManager fileManager =
         new InMemoryJavaFileManager(
             compiler.getStandardFileManager(diagnosticCollector, Locale.getDefault(), UTF_8));
+    Context context = new Context();
     JavacTask task =
         ((JavacTool) compiler)
             .getTask(
@@ -64,7 +66,8 @@ static ParseResult parse(Iterable<? extends JavaFileObject> sources) {
                 diagnosticCollector,
                 ImmutableSet.<String>of(),
                 ImmutableSet.<String>of(),
-                sources);
+                sources,
+                context);
     try {
       Iterable<? extends CompilationUnitTree> parsedCompilationUnits = task.parse();
       List<Diagnostic<? extends JavaFileObject>> diagnostics = diagnosticCollector.getDiagnostics();
@@ -76,6 +79,8 @@ static ParseResult parse(Iterable<? extends JavaFileObject> sources) {
           sortDiagnosticsByKind(diagnostics), parsedCompilationUnits, Trees.instance(task));
     } catch (IOException e) {
       throw new RuntimeException(e);
+    } finally {
+      DummyJavaCompilerSubclass.closeCompiler(context);
     }
   }
 
@@ -175,4 +180,19 @@ Trees trees() {
       return trees;
     }
   }
+
+  // JavaCompiler.compilerKey has protected access until Java 9, so this is a workaround.
+  private static final class DummyJavaCompilerSubclass extends com.sun.tools.javac.main.JavaCompiler {
+    private static void closeCompiler(Context context) {
+      com.sun.tools.javac.main.JavaCompiler compiler = context.get(compilerKey);
+      if (compiler != null) {
+        compiler.close();
+      }
+    }
+
+    private DummyJavaCompilerSubclass() {
+      // not instantiable
+      super(null);
+    }
+  }
 }
