Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't file experimental crash types. #2739

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Don't file experimental crash types. #2739

merged 2 commits into from
Jul 25, 2022

Conversation

oliverchang
Copy link
Collaborator

No description provided.

DonggeLiu
DonggeLiu approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@DonggeLiu DonggeLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jonathanmetzman
jonathanmetzman reviewed Jul 22, 2022
View reviewed changes
src/clusterfuzz/_internal/crash_analysis/crash_analyzer.py


def is_experimental_crash(crash_type):
"""Return whether or not the crash type is experimental."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: returns

@oliverchang oliverchang enabled auto-merge (squash) July 25, 2022 18:30
@oliverchang oliverchang merged commit e922a5e into master Jul 25, 2022
@oliverchang oliverchang deleted the dont-file-experimental branch July 25, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanmetzman jonathanmetzman jonathanmetzman left review comments

@Navidem Navidem Navidem approved these changes

@DonggeLiu DonggeLiu DonggeLiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliverchang @Navidem @DonggeLiu @jonathanmetzman