DefaultTypeAdapter: Add support for missing custom scalars#893
Merged
TristonianJones merged 1 commit intogoogle:masterfrom Feb 2, 2024
Merged
DefaultTypeAdapter: Add support for missing custom scalars#893TristonianJones merged 1 commit intogoogle:masterfrom
TristonianJones merged 1 commit intogoogle:masterfrom
Conversation
952d36c to
9002cb9
Compare
Collaborator
|
/gcbrun |
9002cb9 to
844a9f6
Compare
TristonianJones
previously approved these changes
Feb 1, 2024
Collaborator
|
/gcbrun |
The default type adapter already supports some custom scalar types but not all, this change adds the missing ones. The most only used one is likely string.
844a9f6 to
29d5f28
Compare
Collaborator
|
/gcbrun |
TristonianJones
approved these changes
Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default type adapter already supports some custom scalar types but
not all, this change adds the missing ones. The most only used one is likely string.
Fixes #884
Pull Requests Guidelines
See CONTRIBUTING.md for more details about when to create
a GitHub Pull Request and when other kinds of contributions or
consultation might be more desirable.
When creating a new pull request, please fork the repo and work within a
development branch.
Commit Messages
Reviews
Merging
they have write access. Otherwise, the change will be merged by a maintainer.
closes #<issue-num>: descriptionin the merge message,if applicable.