Minor adjustment to inlining to fix a bad bind#888
Merged
TristonianJones merged 1 commit intogoogle:masterfrom Jan 24, 2024
Merged
Minor adjustment to inlining to fix a bad bind#888TristonianJones merged 1 commit intogoogle:masterfrom
TristonianJones merged 1 commit intogoogle:masterfrom
Conversation
l46kok
approved these changes
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inlining attempted a
bindwhere one was not valid.Whether or not the inlined type would support field tests was not relevant
to whether it could be used in a bind within a presence test. Removed this
single condition which triggers failures as well as a test case to reproduce
the issue.