Rename TRUE and FALSE#134
Merged
TristonianJones merged 2 commits intogoogle:masterfrom Nov 8, 2021
keith:ks/rename-true-and-false
Merged
Rename TRUE and FALSE#134TristonianJones merged 2 commits intogoogle:masterfrom keith:ks/rename-true-and-false
TristonianJones merged 2 commits intogoogle:masterfrom
keith:ks/rename-true-and-false
Conversation
This avoids conflicts with default macros defined by the Windows and macOS SDKs. Fixes: #121
Contributor
Author
|
I have no idea if changing this is safe in general, but here's a potential solution to the linked issue |
TristonianJones
approved these changes
Nov 8, 2021
Collaborator
|
I ran tests internally and all is well with this change. |
Contributor
Author
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids conflicts with default macros defined by the Windows and
macOS SDKs.
Fixes: #121