Repository navigation
CLI: report a failed output write and keep the input - #1537
Merged
copybara-service[bot] merged 3 commits intoOct 21, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
@googlebot I signed it! |
lenamonj
force-pushed
the
cli-report-write-failure
branch
from
September 6, 2026 09:08
665583d to
cfd59fe
Compare
Collaborator
|
Comment in |
Contributor
Author
|
Comment dropped. |
eustas
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When writing the output failed,
brotli --rmstill deleted the input and exited 0.CloseFilesnever flushedfoutitself: the only flush was insideCopyStat, whose failure returns silently, and the unlink of the input ran regardless ofis_ok.CloseFilesnow flushes first and reports a failure, skips the metadata copy after one, and unlinks the input only when the output is known complete.CopyStatno longer flushes.brotli --rm -f -o /dev/full fon master: exit 0,fgone. With this change: exit 1,fkept.