Skip to content

Conversation

@LebedevRI
Copy link
Collaborator

@LebedevRI LebedevRI commented Mar 16, 2020

This reverts commit 5ce2429.

Reverts #923
Reopens #922
Fixes #928
Closes #930

See discussion in #928
this broke pkg-config support, since there we don't account
for the suffix, nor is it trivial to do so.

@LebedevRI LebedevRI added the next-release PRs or Issues that should be included in the next release label Mar 16, 2020
@LebedevRI LebedevRI requested a review from dmah42 March 16, 2020 11:23
This reverts commit 5ce2429.

Reverts #923
Reopens #922
Fixes #928
Closes #930

See discussion in #928
this broke pkg-config support, since there we don't account
for the suffix, nor is it trivial to do so.
@LebedevRI LebedevRI merged commit e30cac6 into master Mar 16, 2020
@LebedevRI LebedevRI deleted the revert-923-master branch March 16, 2020 11:32
JBakamovic pushed a commit to JBakamovic/benchmark that referenced this pull request Sep 11, 2020
This reverts commit 5ce2429.

Reverts google#923
Reopens google#922
Fixes google#928
Closes google#930

See discussion in google#928
this broke pkg-config support, since there we don't account
for the suffix, nor is it trivial to do so.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes next-release PRs or Issues that should be included in the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pkg-config reports incorrect library with Debug build: gcc/Linux

3 participants