Add d postfix to Debug libraries #923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it possible to install Debug and Release versions on the same system. Without this, there were only linker errors when using the wrong configuration.
Member
|
failure looks unrelated. lgtm |
Collaborator
|
(As noted in #928, this broke pkgconfig files) |
LebedevRI
added a commit
that referenced
this pull request
Mar 16, 2020
This reverts commit 5ce2429.
LebedevRI
added a commit
that referenced
this pull request
Mar 16, 2020
LebedevRI
added a commit
that referenced
this pull request
Mar 16, 2020
JBakamovic
pushed a commit
to JBakamovic/benchmark
that referenced
this pull request
Sep 11, 2020
* Add DEBUG_POSTFIX to libraries. Makes it possible to install Debug and Release versions on the same system. Without this, there were only linker errors when using the wrong configuration. * Update CONTRIBUTORS and AUTHORS according to guide
JBakamovic
pushed a commit
to JBakamovic/benchmark
that referenced
this pull request
Sep 11, 2020
This reverts commit 5ce2429. Reverts google#923 Reopens google#922 Fixes google#928 Closes google#930 See discussion in google#928 this broke pkg-config support, since there we don't account for the suffix, nor is it trivial to do so.
JBakamovic
pushed a commit
to JBakamovic/benchmark
that referenced
this pull request
Sep 11, 2020
This reverts commit 5ce2429. Reverts google#923 Reopens google#922 Fixes google#928 Closes google#930 See discussion in google#928 this broke pkg-config support, since there we don't account for the suffix, nor is it trivial to do so.
openvela-robot
pushed a commit
to open-vela/external_googlebenchmark
that referenced
this pull request
Jul 23, 2025
This reverts commit 5ce2429. Reverts google/benchmark#923 Reopens google/benchmark#922 Fixes google/benchmark#928 Closes google/benchmark#930 See discussion in google/benchmark#928 this broke pkg-config support, since there we don't account for the suffix, nor is it trivial to do so.
openvela-robot
pushed a commit
to open-vela/external_googlebenchmark
that referenced
this pull request
Jul 23, 2025
This reverts commit 5ce2429. Reverts google/benchmark#923 Reopens google/benchmark#922 Fixes google/benchmark#928 Closes google/benchmark#930 See discussion in google/benchmark#928 this broke pkg-config support, since there we don't account for the suffix, nor is it trivial to do so.
liujinye-sys
pushed a commit
to open-vela/external_googlebenchmark
that referenced
this pull request
Dec 16, 2025
This reverts commit 5ce2429. Reverts google/benchmark#923 Reopens google/benchmark#922 Fixes google/benchmark#928 Closes google/benchmark#930 See discussion in google/benchmark#928 this broke pkg-config support, since there we don't account for the suffix, nor is it trivial to do so.
liujinye-sys
pushed a commit
to open-vela/external_googlebenchmark
that referenced
this pull request
Dec 16, 2025
This reverts commit 5ce2429. Reverts google/benchmark#923 Reopens google/benchmark#922 Fixes google/benchmark#928 Closes google/benchmark#930 See discussion in google/benchmark#928 this broke pkg-config support, since there we don't account for the suffix, nor is it trivial to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #922, works same as googletest.