Fixture: add non const Setup() and TearDown(). #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows write-access to the State variable, which is important in upcoming user-defined counter functionality.
|
✅ Build benchmark 403 completed (commit 593e40b416 by @jppm) |
include/benchmark/benchmark_api.h
Outdated
| virtual void SetUp(const State&) {} | ||
| virtual void TearDown(const State&) {} | ||
| // ... In favor of these. | ||
| virtual void SetUp(State& st) { SetUp(static_cast<State const&>(st)); } |
Contributor
There was a problem hiding this comment.
Please be consistent wrt the placement of const. This library generally puts it before the type name. (I am in the "after the type name" camp, but consistency trumps.)
|
✅ Build benchmark 405 completed (commit 99e137a332 by @jppm) |
include/benchmark/benchmark_api.h
Outdated
| virtual void SetUp(const State&) {} | ||
| virtual void TearDown(const State&) {} | ||
| // ... In favor of these. | ||
| virtual void SetUp(State& st) { SetUp(static_cast<const State&>(st)); } |
Contributor
There was a problem hiding this comment.
Nah this should be static_cast. const_cast is for removing const.
Member
There was a problem hiding this comment.
gah, completely read it wrong. i thought it was the other way around (with the old ones forwarding to the new ones)
|
✅ Build benchmark 407 completed (commit 44c8fdda78 by @jppm) |
FantasqueX
added a commit
to FantasqueX/benchmark
that referenced
this pull request
Dec 28, 2023
Const SetUp and TearDown were deprecated in google#285
dmah42
added a commit
that referenced
this pull request
Jan 5, 2024
Const SetUp and TearDown were deprecated in #285 Co-authored-by: dominic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows write-access to the State argument, which is important in upcoming user-defined counter functionality.