MaybeReenterWithoutASLR(): be more cautious about argument types
#1983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems, on android the argument is narrower than on linux. Let's try to support that while not introducing any explicit lossy casts. Fixes google#1982
dmah42
approved these changes
May 12, 2025
Contributor
|
I've experimented with it a bit now, but haven't really been successful. The bugfix itself works (see microsoft/vcpkg#45475). I then tried to find out somehow where the issue really comes from, but debugging against the vcpkg-CI just takes a long time and locally CMake ignores the request to cross-compile with Android. But it's not worth investing any more time for me now. In case someone has more experience and wants to play with it: The Android Dockerfile is available here (the image |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems, on android the argument is narrower than on linux. Let's try to support that while not introducing any explicit lossy casts.
Fixes #1982