Update build instructions for Visual Studio #1980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Andrewyuan34
force-pushed
the
win-build-documentation
branch
from
130e65b to
1148a35
Compare
LebedevRI
approved these changes
May 9, 2025
Collaborator
LebedevRI
left a comment
LebedevRI
left a comment
There was a problem hiding this comment.
I'm assuming you've tested this.
@Andrewyuan34 Thank you!
Author
|
@LebedevRI Thanks! I tested it on two independent machines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to set up benchmark environment on Windows and spend quite a bit time to figure out what happened when building with debug mode in Visual Studio.
After this change #947, no 'd' postfix will be generated for debug builds. The library file is consistently named
benchmark.libfor all configurations.btw, I have successfully tested this configuration on two independent machines with Visual Studio 2022. Hopefully it demonstrates the reliability for this setup approach.