Compilation example was wrong. Fixed standard #1945
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| # Example on linux after running the build steps above. Assumes the | ||
| # `benchmark` and `build` directories are under the current directory. | ||
| $ g++ mybenchmark.cc -std=c++11 -isystem benchmark/include \ | ||
| $ g++ mybenchmark.cc -std=c++14 -isystem benchmark/include \ |
There was a problem hiding this comment.
this should be c++17 to be up to date with the library.
There was a problem hiding this comment.
Are there C++17 features in the header? If so, docs are outdated now too.
By the way, with cxx03 test gone, i guess we want to add a cxx14 test,
to ensure that the header can actually be used with the ${version} standard.
There was a problem hiding this comment.
i don't think the header has any C++17 features yet, no, but the door is now open to adding them.
There was a problem hiding this comment.
Aha. Then it certainly might be great to "guard" against that with a test.
|
CLA check still seems to be having issues. |
|
forced a rescan |
LebedevRI
left a comment
LebedevRI
left a comment
There was a problem hiding this comment.
This is an improvement over the current incorrect status-quo.
3 participants
The README.md file put a compile example with the flag
-std=c++11, and because of the use of new standard library functions, the flag in the compile example had to be changed to-std=c++14, this solving issue: #1943