Skip to content

fix sanitizer cmake builds #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmah42 merged 8 commits into from
Feb 6, 2025
Merged

fix sanitizer cmake builds #1906

dmah42 merged 8 commits into from
Feb 6, 2025

Conversation

@dmah42
Copy link
Member

@dmah42 dmah42 commented Jan 13, 2025 •
edited
Loading

  1. upgrade to newer LLVM
  2. use libc++ includes for Isystem and I command line flags
  3. update to C++17 in cmake feature checks

@dmah42
Copy link
Member Author

dmah42 commented Jan 13, 2025

sanitizer failing due to missing <condition_variable> header, but that should be fine with -stdlib=libc++. 🤔

@dmah42 dmah42 mentioned this pull request Jan 14, 2025
Closed
@dmah42 dmah42 marked this pull request as ready for review February 6, 2025 10:54
@dmah42
Copy link
Member Author

dmah42 commented Feb 6, 2025

the remaining msan failures are real ones, not build setup ones.

@dmah42 dmah42 merged commit 9d8201e into main Feb 6, 2025
94 of 101 checks passed
@dmah42 dmah42 deleted the fixsan branch February 6, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dmah42