the segfault on cxx03_test is a bit of a surprise. i'm debating whether, given we now require c++17 to build the library, it's time to drop the cxx03 stuff and clean everything up anyway.

cc @LebedevRI

so the issue here is that the check for BENCHMARK_HAS_CXX11 is checking if the compiler supports c++11 and not if the current --std is set to C++11 (or greater). so we end up using c++11 style enum definitions which somehow compile even though the standard is set to not support them. this then causes issues with where various pointers are pointing, etc, etc, we get a jump to an invalid address.

i think the right way to do this would be a cxx compiler check in cmake that tries to compile the enum with type, setting a define specifically for that support, then use that in place of the CXX11 check.

or we get rid of the cxx03 stuff altogether now we require C++17 :)

running a straw poll on the discord

see #1903 and #1906 for followons.