Skip to content

Conversation

@nicholasjng
Copy link
Contributor

Adds support for free-threaded nanobind extension builds, though we don't currently build a free-threaded wheel.

Adds support for free-threaded nanobind extension builds, though we
don't currently build a free-threaded wheel.
@nicholasjng
Copy link
Contributor Author

Since Python 3.13 has been released, I'll also add it to cibuildwheel and the Python bindings test matrix shortly if that's ok with you.

@dmah42
Copy link
Member

dmah42 commented Oct 23, 2024

looks like googletest got accidentally upgraded (WARNING: For repository 'com_google_googletest', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.)

amongst others:

WARNING: For repository 'bazel_skylib', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'platforms', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'rules_python', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'com_google_googletest', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.

we might want to do an explicit upgrade before this can land.

@dmah42
Copy link
Member

dmah42 commented Oct 23, 2024

#1867 should do it

@nicholasjng
Copy link
Contributor Author

Sure. Is there another version before their latest C++17 upgrade? Otherwise this might have to wait for the upgrade to C++17.

@dmah42 dmah42 merged commit be21345 into google:main Oct 23, 2024
@dmah42
Copy link
Member

dmah42 commented Oct 23, 2024

thank you for your continued maintenance of this dark corner of the project!

@nicholasjng
Copy link
Contributor Author

My pleasure, I'll be here for a while :^)

@nicholasjng nicholasjng deleted the bump-nanobind-bazel branch October 23, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants