"error: use of the 'maybe_unused' attribute is a C++17 extension [clang-diagnostic-c++17-attribute-extensions]" looks like gtest moved to C++17 and we're using clang-tidy-14.

so we can bump clang-tidy but i wonder if we also need to make sure when we build for tests we're building on c++17?

From the previously shared page - https://opensource.google/documentation/policies/cplusplus-support#support_criteria_4

What would the earliest C++ standard you'd support? I guess technically it's 10 years since C++14.

From the previously shared page - https://opensource.google/documentation/policies/cplusplus-support#support_criteria_4

What would the earliest C++ standard you'd support? I guess technically it's 10 years since C++14.

https://github.com/google/benchmark/blob/main/CMakeLists.txt#L141 is what we currently support. though if gtest has moved to require c++ 17 we can do that now based on the 10 year rule. i have a calendar reminder for the first week of January to flip to 17 then :)

in #1867 i've updated to an interim version. maybe that version is enough to make the cmake change work?

#1868 bumps partially and updates cmake. are you ok with me merging that or do you want to change this to match, or keep iterating on this to support c++17?