Skip to content

Conversation

@dmah42
Copy link
Member

@dmah42 dmah42 commented Sep 12, 2024

Added the functionality for a dry run benchmark called through the cli argument --benchmark_dry_run.

authored by @Shaan-Mistry

@dmah42 dmah42 mentioned this pull request Sep 12, 2024
@dmah42 dmah42 merged commit 72ecc4e into main Sep 12, 2024
@dmah42 dmah42 deleted the Shaan-Mistry-feature/dry-run-argument branch September 12, 2024 14:50
@LebedevRI
Copy link
Collaborator

One thing to note, this does not handle the batch-casing.
Oh, and docs/test could be useful. I've wanted to comment while the review was going, but never got around to.

@dmah42
Copy link
Member Author

dmah42 commented Sep 13, 2024

good note. added documentation at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants