mitigate clang build warnings -Wconversion #1763
Conversation
|
Yup, implicit conversions is perhaps one of the worst C/C++ "features". |
it's in bazel for tests only (!!). i'll see about improving that. |
include/benchmark/benchmark.h
Outdated
| int ArgsCnt() const; | ||
| const char* GetArgName(int arg) const; | ||
| const char* GetArgName(size_t arg) const; |
There was a problem hiding this comment.
I'm not sure about this one, we return signed and then take unsigned.
I think things should generally be signed, but even then, this seems unconsistent
There was a problem hiding this comment.
yeah i didn't feel great about that either. i'll tweak it.
|
|
||
| static const T kmax = std::numeric_limits<T>::max(); | ||
|
|
||
| // Space out the values in multiples of "mult" |
There was a problem hiding this comment.
I'm somewhat surprized that this is needed, but okay, i guess?
LebedevRI
left a comment
LebedevRI
left a comment
There was a problem hiding this comment.
Seems fine to me, thank you!
2 participants
No description provided.