Skip to content

Revert "fix some warnings"#1762

Merged
dmah42 merged 1 commit into
google:mainfrom
LebedevRI:revert
Mar 6, 2024
Merged

Revert "fix some warnings"#1762
dmah42 merged 1 commit into
google:mainfrom
LebedevRI:revert

Conversation

@LebedevRI

Copy link
Copy Markdown
Collaborator

This reverts commit 1576991.

This reverts commit 1576991.
@LebedevRI LebedevRI requested a review from dmah42 March 5, 2024 23:05
@dmah42

dmah42 commented Mar 6, 2024

Copy link
Copy Markdown
Member

but why? i had local compiler warnings due to potential size differences.

@LebedevRI

Copy link
Copy Markdown
Collaborator Author

but why? i had local compiler warnings due to potential size differences.

Because the CI was green before that change, and went red after that change.
I think branch protection rules are wrong, they either prevent everyone from bypassing them, or nobody.

@dmah42

dmah42 commented Mar 6, 2024

Copy link
Copy Markdown
Member

but why? i had local compiler warnings due to potential size differences.

Because the CI was green before that change, and went red after that change. I think branch protection rules are wrong, they either prevent everyone from bypassing them, or nobody.

oh right. that's fair.

@dmah42 dmah42 merged commit ef88520 into google:main Mar 6, 2024
@LebedevRI LebedevRI deleted the revert branch March 6, 2024 12:41
@LebedevRI

Copy link
Copy Markdown
Collaborator Author

@dmah42 thank you!
I'm sure the whatever diagnostics those changes were trying to address
can be addressed without reintroducing that breakage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants