Issue 1734: Streams not flushed if not running actual benchmarks#1735
Merged
Conversation
…RunBenchmarks, the Out and Err streams are flushed before exiting.
Collaborator
|
I suppose this makes sense, we can't quite be sure that |
Contributor
Author
|
Added some more calls to Out.flush() and Err.flush() |
Contributor
Author
|
I noted that there is a complexity test failing, but not sure why. |
LebedevRI
reviewed
Jan 9, 2024
Contributor
Author
|
@LebedevRI, you,re welcome... Just started to use the library - it's really cool. |
Collaborator
|
I'm not sure why those |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the call paths in RunSpecifiedBenchmarks do not go into internal::RunBenchmarks, the Out and Err streams are flushed before exiting.