Update bzlmod support to new rules_python extension API #1633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsharpe
commented
Jul 16, 2023
| incompatible_generate_aliases = True, | ||
| python_interpreter_target="@interpreter//:python", | ||
| hub_name="tools_pip_deps", | ||
| python_version = "3.9", |
Author
There was a problem hiding this comment.
It's possible this line shouldn't be here; am in discussion with the rules_python authors around this design decision as this is problematic when the main repo declares a different default python_version.
Member
There was a problem hiding this comment.
i see.. so this can be different to the python.toolchain declared above?
Author
There was a problem hiding this comment.
dmah42
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bzlmod extension API in rules_python before version 0.24.0 was marked as experimental and has changed.
Its expected that the 0.24.0 API should now be more stable as feature parity has been achieved with the non-bzlmod variant.