Skip to content

Conversation

@ii14
Copy link

@ii14 ii14 commented Jul 3, 2023

No description provided.

@google-cla
Copy link

google-cla bot commented Jul 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

"tmux-256color", "rxvt-unicode", "rxvt-unicode-256color",
"linux", "cygwin",
"linux", "cygwin", "xterm-kitty",
"alacritty",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference for alacritty supporting color?

Copy link
Author

@ii14 ii14 force-pushed the feat/more_color_terminals branch from d9fd837 to e03aadf Compare July 3, 2023 20:30
@ii14
Copy link
Author

ii14 commented Jul 3, 2023

Looks like CLA requires a Google account. Is it really necessary for such a tiny change?

@dmah42
Copy link
Member

dmah42 commented Jul 4, 2023

https://cla.developers.google.com/about

i'm afraid we do need CLAs for any contributions, and our CLA does require a Google account.

@ii14
Copy link
Author

ii14 commented Jul 4, 2023

Maybe I'll figure this out some other day then. In the meantime, if anyone wants to, feel free to apply this patch under your own name as the author.

@ii14
Copy link
Author

ii14 commented Jul 4, 2023

Superseded by #1621

@ii14 ii14 closed this Jul 4, 2023
@ii14 ii14 deleted the feat/more_color_terminals branch July 4, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants