-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add more terminals with color support #1620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| "tmux-256color", "rxvt-unicode", "rxvt-unicode-256color", | ||
| "linux", "cygwin", | ||
| "linux", "cygwin", "xterm-kitty", | ||
| "alacritty", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference for alacritty supporting color?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under CSI m: https://github.com/alacritty/alacritty/blob/edf4df66c9afcb9593eaeaaf34d5c80c66925adc/docs/escape_support.md#csi-control-sequence-introducer---esc-
terminfo: https://github.com/alacritty/alacritty/blob/edf4df66c9afcb9593eaeaaf34d5c80c66925adc/extra/alacritty.info
d9fd837 to
e03aadf
Compare
|
Looks like CLA requires a Google account. Is it really necessary for such a tiny change? |
|
i'm afraid we do need CLAs for any contributions, and our CLA does require a Google account. |
|
Maybe I'll figure this out some other day then. In the meantime, if anyone wants to, feel free to apply this patch under your own name as the author. |
|
Superseded by #1621 |
No description provided.