Refactoring of PerfCounters infrastructure #1559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main feature in this pull request is the removal of the static sharing of PerfCounters and instead creating them at the top `RunBenchmarks()` function where all benchmark runners are created. A single PerfCountersMeasurement object is created and then shared with all the new BenchmarkRunners objects, one per existing benchmark. Other features conflated here in this PR are: - Added BENCHMARK_DONT_OPTIMIZE macro in global scope - Removal of the `IsValid()` query, being replaced by checking the number of remaining counters after validity tests - Refactoring of all GTests to reflect the changes and new semantics - extra comments throughout the new code to clarify intent It was extremely hard to separate all those features in different PRs as requested since they are so interdependent on each other so I'm just pushing them altogether and asking for forgiveness. This PR comes replacing PRs 1555 and 1558 which have been closed.
This was referenced Mar 4, 2023
My clang-format insists in deleting this single white space on line 601 while Github's clang format breaks when it is added. I had to disable format-on-save to check-in this revert change. I'm using clang 14.0.6.
Contributor
Author
|
The Bazel failures dont seem related to code. What to do? |
dmah42
approved these changes
Mar 6, 2023
Member
|
rerunning the osx one, that looks like a local failure. the windows one seems like some timings changed away from expectations. that shouldn't be related to this PR. i'l try rerunning that too. |
mtrofin
reviewed
Mar 6, 2023
Contributor
|
lgtm, some nits |
Contributor
Author
Maybe because some tests are now running in full while before they were being collapsed by the compiler? |
Member
|
thanks for all the iterations :D |
jmr
reviewed
Aug 16, 2023
| reports_for_family = &per_family_reports[benchmark.family_index()]; | ||
|
|
||
| runners.emplace_back(benchmark, reports_for_family); | ||
| benchmarks_with_threads += (benchmark.threads() > 0); |
Member
There was a problem hiding this comment.
It looks like this is always true. Should it be threads() > 1?
jmr
added a commit
to jmr/benchmark
that referenced
this pull request
Aug 17, 2023
Change condition for `benchmarks_with_threads` from `benchmark.threads() > 0` to `> 1`. `threads()` appears to always be `>= 1`. Introduced in fbc6efa (Refactoring of PerfCounters infrastructure (google#1559))
jmr
added a commit
to jmr/benchmark
that referenced
this pull request
Aug 17, 2023
Change condition for `benchmarks_with_threads` from `benchmark.threads() > 0` to `> 1`. `threads()` appears to always be `>= 1`. Introduced in fbc6efa (Refactoring of PerfCounters infrastructure (google#1559))
dmah42
pushed a commit
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main feature in this pull request is the removal of the static sharing of PerfCounters and instead creating them at the top
RunBenchmarks()function where all benchmark runners are created. A single PerfCountersMeasurement object is created and then shared with all the new BenchmarkRunners objects, one per existing benchmark.Other features conflated here in this PR are:
IsValid()query, being replaced by checking the number of remaining counters after validity testsIt was truly impossible to separate all those features in different PRs as requested since they are so interdependent on each other so I'm just pushing them together and asking for forgiveness.
This PR comes replacing PRs 1555 and 1558 which have been closed.