-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Description
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Google benchmark looks to be using libc functions like fseeko, ftello, fopen. (IIUC, std::ifstream may results in using these functions.)
On some "small" platforms, it might result in EOVERFLOW when dealing with large files.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Compiles with these three flags enabled:
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE.
this is the portable/POSIX method for transparently using 64bit types everywhere. for details on each define, see:
# http://www.gnu.org/s/libc/manual/html_node/Feature-Test-Macros.html
# _LARGEFILE_SOURCE: enable support for new LFS funcs (ftello/etc...)
# _LARGEFILE64_SOURCE: enable support for 64bit variants (off64_t/fseeko64/etc...)
# _FILE_OFFSET_BITS: default to 64bit variants (off_t is defined as off64_t)
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
N/A
Additional context
Add any other context or screenshots about the feature request here.