Fix an issue with setup scripts in tox.ini.#9
Closed
craigcitro wants to merge 1 commit intogoogle:masterfrom
Closed
Fix an issue with setup scripts in tox.ini.#9craigcitro wants to merge 1 commit intogoogle:masterfrom
craigcitro wants to merge 1 commit intogoogle:masterfrom
Conversation
This tweaks `tox.ini` to install additional packages in such a way that we don't run afoul of the issues in google#4.
Contributor
|
@craigcitro the first example uses the I think I would probably just punt on the DRY and inline the list into |
Contributor
|
The Travis 3.4 failure is likely due to hash order stuff: pass |
Contributor
Author
Contributor
|
My take on a better fix is in #10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tweaks
tox.inito install additional packages in such a way that wedon't run afoul of the issues in #4.
@tseaver do you have any sense for why this would fix the failures we're seeing in #4? this is far beyond my python-packaging-fu. in particular, danny found this link with the fix, but I'm still confused as to why this particular fix works, whereas other attempts (including not calling
pipfrom insidetox.ini) didn't.