Skip to content

Testing neaten#10

Closed
tseaver wants to merge 2 commits intogoogle:masterfrom
tseaver:testing-neaten
Closed

Testing neaten#10
tseaver wants to merge 2 commits intogoogle:masterfrom
tseaver:testing-neaten

Conversation

@tseaver
Copy link
Copy Markdown
Contributor

@tseaver tseaver commented Mar 31, 2015

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 39.85% when pulling ebaf9b5 on tseaver:testing-neaten into c431900 on google:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 39.85% when pulling ebaf9b5 on tseaver:testing-neaten into c431900 on google:master.

Comment thread .travis.yml
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes builds faster (at least, puts us in a higher throughput queue), and travis is trying to push everyone that direction anyway.

@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Mar 31, 2015

This still fails to finish the install and does not fix #4 on my machine: https://gist.github.com/dhermes/f0c0650526c8d62f9230

In particular, check out the results of ls -1 .tox/py27/bin/g* after the first and second runs of tox -e py27. The failure is because gen_client doesn't get created when the environment is brand new

@craigcitro
Copy link
Copy Markdown
Contributor

@dhermes just to confirm: is this just a vanilla ubuntu 14.04 machine? if so i want to try and repro this in GCE, to understand what's going on.

either this is an issue in my tox.ini/setup.py, or it's a bug in tox. i'm quite wary about claiming the latter.

@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Mar 31, 2015

Yes vanilla Ubuntu. (Also I got sudo: false mixed up with sudo: true; we use false in gcloud-python and I'm the one that committed it.)

@craigcitro
Copy link
Copy Markdown
Contributor

grr, so i can't repro this on a GCE instance. you're 14.04, with recent python/pip/tox?

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Mar 31, 2015

@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Mar 31, 2015

$ uname -a
Linux ubuntlaptop 3.13.0-48-generic #80-Ubuntu SMP Thu Mar 12 11:16:15 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=14.04
DISTRIB_CODENAME=trusty
DISTRIB_DESCRIPTION="Ubuntu 14.04.2 LTS"
$ tox --version
1.9.2 imported from /usr/local/lib/python2.7/dist-packages/tox/__init__.pyc
$ pip --version
pip 6.0.8 from /usr/local/lib/python2.7/dist-packages (python 2.7)

@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Mar 31, 2015

Why are we wrestling all this when the failing test needs to be pulled out into a system / integration test anyhow?

@craigcitro
Copy link
Copy Markdown
Contributor

@dhermes so i don't care about the test so much -- but the core issue is that apitools isn't getting installed correctly on your machine, right?

or is this only under tox?

@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Mar 31, 2015

@craigcitro It's only under tox. I just tried with a virtual env and had no issues:

$ virtualenv venv
...
$ source venv/bin/activate
...
(venv)$ which gen_client
# Nothing
(venv)$ pip install google-apitools[testing]
...  # No failures printed
(venv)$ which gen_client
...venv/bin/gen_client

@craigcitro
Copy link
Copy Markdown
Contributor

@dhermes so wait -- if you just add a new tox env with

[testenv:confusion]
basepython = python2.7
deps = 
    mock
    nose
commands = echo "hello"

and run tox -e confusion, the new env doesn't have gen_client at all?

@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Apr 2, 2015

tox doesn't like echo, so I replaced with commands = python -c 'print "hello"'.

Just as with py27, the first run fails to create gen_client and the second does so successfully:
https://gist.github.com/dhermes/6b42e9242c4f531ea643

@craigcitro
Copy link
Copy Markdown
Contributor

@dhermes does it say anything insightful if you do tox -v -v?

@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Apr 2, 2015

Nope. But it did point out that on the first run, the "install" gets logged to .tox/py27/log/py27-2.log and on the second run to .tox/log/tox-0.log. The first log is very different, it runs

pip install .tox/dist/google-apitools-0.4.1.zip

while the second runs

python setup.py sdist ...

to recreate the zip.

@cherba
Copy link
Copy Markdown
Contributor

cherba commented Sep 30, 2016

Is anyone still pursuing this PR, do you mind if we close it?

@tseaver
Copy link
Copy Markdown
Contributor Author

tseaver commented Sep 30, 2016

I'm not pushing for it.

@tseaver tseaver closed this Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants